[llvm-branch-commits] [llvm] [BOLT] Match blocks with pseudo probes (PR #99891)

via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Wed Jul 24 13:55:09 PDT 2024


================
@@ -478,10 +605,31 @@ matchWeightsByHashes(BinaryContext &BC,
     Blocks.push_back(&Func.Blocks[I + 1]);
     BlendedBlockHash BlendedHash(BB->getHash());
     BlendedHashes.push_back(BlendedHash);
+    // Collects pseudo probes attached to the BB for use in the StaleMatcher.
+    if (opts::ProfileUsePseudoProbes && PseudoProbeDecoder) {
+      const AddressProbesMap &ProbeMap =
+          PseudoProbeDecoder->getAddress2ProbesMap();
+      const uint64_t FuncAddr = BF.getAddress();
+      const std::pair<uint64_t, uint64_t> &BlockRange =
+          BB->getInputAddressRange();
+      const auto &BlockProbes =
+          llvm::make_range(ProbeMap.lower_bound(FuncAddr + BlockRange.first),
+                           ProbeMap.lower_bound(FuncAddr + BlockRange.second));
+      for (const auto &[_, Probes] : BlockProbes) {
+        for (const MCDecodedPseudoProbe &Probe : Probes) {
+          if (Probe.getInlineTreeNode()->hasInlineSite())
----------------
WenleiHe wrote:

If we think probe is a reliable anchor for block level profile-binary matching, we should find ways to leverage inlinee probes for matching inlinee blocks too. Operating with only top level probes can be very limiting. 

https://github.com/llvm/llvm-project/pull/99891


More information about the llvm-branch-commits mailing list