[llvm-branch-commits] [misexpect] Support diagnostics from frontend profile data (PR #96524)

Paul Kirth via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Mon Jul 22 09:24:07 PDT 2024


================
@@ -369,9 +369,21 @@ static bool lowerExpectIntrinsic(Function &F) {
     if (BranchInst *BI = dyn_cast<BranchInst>(BB.getTerminator())) {
       if (handleBranchExpect(*BI))
         ExpectIntrinsicsHandled++;
+      else {
+        SmallVector<uint32_t> Weights;
+        if (extractBranchWeights(*BI, Weights))
+          misexpect::checkMissingAnnotations(*BI, Weights,
+                                             /*IsFrontendInstr=*/false);
----------------
ilovepi wrote:

oh no! You're right, this is basically dead. Let me go through this and try to figure out why I thought this was working as intended.

https://github.com/llvm/llvm-project/pull/96524


More information about the llvm-branch-commits mailing list