[llvm-branch-commits] [clang] ab0a565 - Revert "fix bug that undefined internal is a warning only for -pedantic-error…"

[via llvm-branch-commits]

Author: Aaron Ballman
Date: 2024-07-11T12:59:40-04:00
New Revision: ab0a5654ce418b73bbc04dee37e7f2dd4f75a6e4

URL: https://github.com/llvm/llvm-project/commit/ab0a5654ce418b73bbc04dee37e7f2dd4f75a6e4
DIFF: https://github.com/llvm/llvm-project/commit/ab0a5654ce418b73bbc04dee37e7f2dd4f75a6e4.diff

LOG: Revert "fix bug that undefined internal is a warning only for -pedantic-error…"

This reverts commit e16882fc7416a30d56d5b5a19d549ca7c653e668.

Added: 
    

Modified: 
    clang/docs/ReleaseNotes.rst
    clang/include/clang/Basic/DiagnosticSemaKinds.td

Removed: 
    clang/test/Sema/undefined-internal-basic.c
    clang/test/Sema/undefined-internal-typeof-c23.c


################################################################################
diff  --git a/clang/docs/ReleaseNotes.rst b/clang/docs/ReleaseNotes.rst
index d5446f7fd92cc..c6a2237113ace 100644
--- a/clang/docs/ReleaseNotes.rst
+++ b/clang/docs/ReleaseNotes.rst
@@ -592,9 +592,6 @@ Attribute Changes in Clang
 
 Improvements to Clang's diagnostics
 -----------------------------------
-- Clang now emits an error instead of a warning for ``-Wundefined-internal``
-  when compiling with `-pedantic-errors` to conform to the C standard
-
 - Clang now applies syntax highlighting to the code snippets it
   prints.
 

diff  --git a/clang/include/clang/Basic/DiagnosticSemaKinds.td b/clang/include/clang/Basic/DiagnosticSemaKinds.td
index 0ea3677355169..940f9ac226ca8 100644
--- a/clang/include/clang/Basic/DiagnosticSemaKinds.td
+++ b/clang/include/clang/Basic/DiagnosticSemaKinds.td
@@ -6016,7 +6016,7 @@ def note_deleted_assign_field : Note<
   "because field %2 is of %select{reference|const-qualified}4 type %3">;
 
 // These should be errors.
-def warn_undefined_internal : ExtWarn<
+def warn_undefined_internal : Warning<
   "%select{function|variable}0 %q1 has internal linkage but is not defined">,
   InGroup<DiagGroup<"undefined-internal">>;
 def err_undefined_internal_type : Error<

diff  --git a/clang/test/Sema/undefined-internal-basic.c b/clang/test/Sema/undefined-internal-basic.c
deleted file mode 100644
index baf05d474250e..0000000000000
--- a/clang/test/Sema/undefined-internal-basic.c
+++ /dev/null
@@ -1,29 +0,0 @@
-// RUN: %clang_cc1 -fsyntax-only -verify %s -Wno-pointer-arith -Wno-gnu-alignof-expression -Wno-unused -pedantic-errors
-
-static void *a(void); // expected-error {{function 'a' has internal linkage but is not defined}}
-static void *b(void); // expected-error {{function 'b' has internal linkage but is not defined}}
-static void *c(void); // expected-error {{function 'c' has internal linkage but is not defined}}
-static void *d(void); // expected-error {{function 'd' has internal linkage but is not defined}}
-static void *no_err(void);
-
-int main(void)
-{
-    a; // expected-note {{used here}}
-    
-    int i = _Alignof(no_err);
-
-    int j = _Generic(&no_err, void *(*)(void): 0);
-
-    void *k = _Generic(&no_err, void *(*)(void): b(), default: 0); // expected-note {{used here}}
-
-    // FIXME according to the C standard there should be no error if the undefined internal is
-    // "part of the expression in a generic association that is not the result expression of its generic selection;"
-    // but, currently, clang wrongly emits an error in this case
-    k = _Generic(&no_err, void *(*)(void): 0, default: c()); // expected-note {{used here}}
-
-    k = _Generic(&no_err, int (*)(void) : 0, default : d()); // expected-note {{used here}}
-
-    int l = sizeof(no_err);
-
-    __typeof__(&no_err) x;
-}

diff  --git a/clang/test/Sema/undefined-internal-typeof-c23.c b/clang/test/Sema/undefined-internal-typeof-c23.c
deleted file mode 100644
index 837c36d4910a7..0000000000000
--- a/clang/test/Sema/undefined-internal-typeof-c23.c
+++ /dev/null
@@ -1,10 +0,0 @@
-// RUN: %clang_cc1 -fsyntax-only -verify %s -std=c23 -pedantic-errors
-
-// expected-no-diagnostics
-
-static int f(void);
-
-int main(void)
-{
-    typeof(&f) x;
-}