[llvm-branch-commits] [flang] [Flang][OpenMP] Refactor loop-related lowering for composite support (PR #97566)
Tom Eccles via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Thu Jul 4 03:42:25 PDT 2024
================
@@ -1492,7 +1466,7 @@ genParallelOp(lower::AbstractConverter &converter, lower::SymMap &symTable,
firOpBuilder.createBlock(®ion, /*insertPt=*/{}, allRegionArgTypes,
allRegionArgLocs);
- llvm::SmallVector<const semantics::Symbol *> allSymbols = reductionSyms;
+ llvm::SmallVector<const semantics::Symbol *> allSymbols(reductionSyms);
----------------
tblah wrote:
ultra-nit, feel free to ignore
Personally I don't like using `()` here because it can parse (to humans and computers) like a function declaration.
```suggestion
llvm::SmallVector<const semantics::Symbol *> allSymbols{reductionSyms};
```
https://github.com/llvm/llvm-project/pull/97566
More information about the llvm-branch-commits
mailing list