[llvm-branch-commits] [llvm] [asan] isInterestingAlloca: remove the isAllocaPromotable condition (PR #77221)

Vitaly Buka via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Wed Feb 14 23:56:48 PST 2024


vitalybuka wrote:

> We can set `-mllvm -stack-safety-run` to force `getInfo`, but it seems that the current lazy `getInfo` works as intended once this patch is applied.

No, we don't need any new flag.
We need to trigger getInfo before any module modification, e.g. at getResult<StackSafetyGlobalAnalysis>
if some function without alloca replaces mem intrinsic, results of calculation of StackSafetyGlobalAnalysis after that will be incorrect (still it's just missed optimization, unnecessary instrumentation).

Any way, no need to do so in this patch.


https://github.com/llvm/llvm-project/pull/77221


More information about the llvm-branch-commits mailing list