[llvm-branch-commits] [llvm] [asan] isInterestingAlloca: remove the isAllocaPromotable condition (PR #77221)

Vitaly Buka via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Wed Feb 14 23:47:47 PST 2024


================
@@ -1279,9 +1278,6 @@ bool AddressSanitizer::isInterestingAlloca(const AllocaInst &AI) {
       (AI.getAllocatedType()->isSized() &&
----------------
vitalybuka wrote:

ClSkipPromotableAllocas on line 1315 is confusing, and maybe unnecessary?
but after your rename it's still confusing

this check applies only to accesses, there is other stuff done to instrument alloca, and ClSkipPromotableAllocas was applied there thru isInterestingAlloca

https://github.com/llvm/llvm-project/pull/77221


More information about the llvm-branch-commits mailing list