[llvm-branch-commits] [lldb][Process] Introduce LoongArch64 hw break/watchpoint support (PR #118770)

[David Spickett via llvm-branch-commits]

================
@@ -0,0 +1,34 @@
+//===-- NativeRegisterContextDBReg_loongarch.h ------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef lldb_NativeRegisterContextDBReg_loongarch_h
+#define lldb_NativeRegisterContextDBReg_loongarch_h
+
+#include "Plugins/Process/Utility/NativeRegisterContextDBReg.h"
+
+namespace lldb_private {
+
+class NativeRegisterContextDBReg_loongarch : public NativeRegisterContextDBReg {
+public:
+  explicit NativeRegisterContextDBReg_loongarch(uint32_t enable_bit)
----------------
DavidSpickett wrote:

Maybe I should give more context so we are on the same page:
```
class NativeRegisterContextDBReg_loongarch : public NativeRegisterContextDBReg {
public:
  explicit NativeRegisterContextDBReg_loongarch()
     : NativeRegisterContextDBReg(<enable_bit_value>) {}
```
Though the `explicit` is probably redundant or invalid when there are no constructor arguments.

The point is that all calls to `NativeRegisterContextDBReg_loongarch(` would be passing the same value for enable_it.

Is doing that giving you the same error? I will try it locally, maybe I have misunderstood the code.

https://github.com/llvm/llvm-project/pull/118770