[llvm-branch-commits] [llvm] AMDGPU/NewPM: Fill out passes in addCodeGenPrepare (PR #102867)

Matt Arsenault via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Tue Aug 13 03:41:25 PDT 2024


================
@@ -106,3 +135,12 @@ Error AMDGPUCodeGenPassBuilder::addInstSelector(AddMachinePass &addPass) const {
   addPass(SILowerI1CopiesPass());
   return Error::success();
 }
+
+bool AMDGPUCodeGenPassBuilder::isPassEnabled(const cl::opt<bool> &Opt,
----------------
arsenm wrote:

> IMO adding code noise around these flags is a good thing since these flags are undesirable.

I'm not moved by this argument at all 

https://github.com/llvm/llvm-project/pull/102867


More information about the llvm-branch-commits mailing list