[llvm-branch-commits] [llvm] AMDGPU/NewPM: Fill out passes in addCodeGenPrepare (PR #102867)

[Arthur Eubanks via llvm-branch-commits]

================
@@ -106,3 +135,12 @@ Error AMDGPUCodeGenPassBuilder::addInstSelector(AddMachinePass &addPass) const {
   addPass(SILowerI1CopiesPass());
   return Error::success();
 }
+
+bool AMDGPUCodeGenPassBuilder::isPassEnabled(const cl::opt<bool> &Opt,
----------------
aeubanks wrote:

I'd prefer if we avoided adding this method, since it makes it too easy code-wise to keep around these flags. This might require cleaning up some flags so that we don't have to inline this method in so many places. IMO adding code noise around these flags is a good thing since these flags are undesirable.

https://github.com/llvm/llvm-project/pull/102867