[llvm-branch-commits] [OpenMP][MLIR] Descriptor explicit member map lowering changes (PR #96265)
Sergio Afonso via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Mon Aug 12 05:12:53 PDT 2024
================
@@ -2541,6 +2541,31 @@ static void processMapMembersWithParent(
assert(memberDataIdx >= 0 && "could not find mapped member of structure");
+ // If we're currently mapping a pointer to a block of data, we must
+ // initially map the pointer, and then attatch/bind the data with a
+ // subsequent map to the pointer, this segment of code generates the
+ // pointer mapping. This pointer map can in certain cases be optimised
+ // out as Clang currently does in its lowering, however, for the moment
+ // we do not do so, in part as we have substantially less information on
+ // the data being mapped at this stage; at least for the moment.
----------------
skatrak wrote:
```suggestion
// we do not do so, in part as we currently have substantially less information
// on the data being mapped at this stage.
```
https://github.com/llvm/llvm-project/pull/96265
More information about the llvm-branch-commits
mailing list