[llvm-branch-commits] [OpenMP][MLIR] Descriptor explicit member map lowering changes (PR #96265)

Sergio Afonso via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Mon Aug 12 05:12:53 PDT 2024


================
@@ -1064,16 +1064,15 @@ static void printMapClause(OpAsmPrinter &p, Operation *op,
 }
 
 static ParseResult parseMembersIndex(OpAsmParser &parser,
-                                     DenseIntElementsAttr &membersIdx) {
-  SmallVector<APInt> values;
+                                     ArrayAttr &membersIdx) {
+  SmallVector<Attribute, 4> values, memberIdxs;
----------------
skatrak wrote:

Nit: Is there a reason for the magic number "4" here? If not, it's generally preferred to leave the default (or zero, if it refuses to give you a compile-time default).

https://github.com/llvm/llvm-project/pull/96265


More information about the llvm-branch-commits mailing list