[llvm-branch-commits] [RISCV] Generate profiles from RISCVProfiles.td (PR #90187)
Alex Bradbury via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Fri Apr 26 06:24:10 PDT 2024
https://github.com/asb commented:
Probably best reviewed by someone who has more familiarity with RISCVTargetDefEmitter, but I took a look anyway.
I think this direction is OK, though I can't help but feel moving from the ISA naming strings to the more verbose listing of features is a bit of a regression in terms of ease of reading. I guess we'd be stuck with a recursive dependency if we wanted tablegen to be able to parse RISC-V ISA strings, as we'd be relying on the tablegenned extension definitions.
https://github.com/llvm/llvm-project/pull/90187
More information about the llvm-branch-commits
mailing list