[llvm-branch-commits] [flang] [flang][OpenMP] Move clause/object conversion to happen early, in genOMP (PR #87086)

[Sergio Afonso via llvm-branch-commits]

================
@@ -597,14 +599,11 @@ static void removeStoreOp(mlir::Operation *reductionOp, mlir::Value symVal) {
 // TODO: Generate the reduction operation during lowering instead of creating
 // and removing operations since this is not a robust approach. Also, removing
 // ops in the builder (instead of a rewriter) is probably not the best approach.
-static void
-genOpenMPReduction(Fortran::lower::AbstractConverter &converter,
-                   Fortran::semantics::SemanticsContext &semaCtx,
-                   const Fortran::parser::OmpClauseList &clauseList) {
+static void genOpenMPReduction(Fortran::lower::AbstractConverter &converter,
+                               Fortran::semantics::SemanticsContext &semaCtx,
+                               const List<Clause> &clauses) {
----------------
skatrak wrote:

Nit: I'm generally in favor of using `ArrayRef<T>` in place of `const Container<T> &` for function arguments in all `gen...` functions here and the constructor for `ClauseProcessor`, but if you don't agree I don't think it's a reason to withhold approval either.

https://github.com/llvm/llvm-project/pull/87086