[llvm-branch-commits] [lldb] bd39a5c - [lldb/test] Automatically skip remote lldb-server tests when applicable
Pavel Labath via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Sun Dec 27 05:10:32 PST 2020
Author: Pavel Labath
Date: 2020-12-27T13:58:10+01:00
New Revision: bd39a5cb30a34547eb56a81eb7ca8aca23544099
URL: https://github.com/llvm/llvm-project/commit/bd39a5cb30a34547eb56a81eb7ca8aca23544099
DIFF: https://github.com/llvm/llvm-project/commit/bd39a5cb30a34547eb56a81eb7ca8aca23544099.diff
LOG: [lldb/test] Automatically skip remote lldb-server tests when applicable
The tests don't work with remote debugservers. This isn't a problem with
any particular test, but the test infrastructure itself, which is why
each of these tests has a @skipIfDarwinEmbedded decorator.
This patch replaces that with a central category-based solution. It also
moves the ad-hoc windows skipping mechanism there too.
Added:
Modified:
lldb/packages/Python/lldbsuite/test/dotest.py
lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py
lldb/test/API/tools/lldb-server/TestGdbRemoteAttach.py
lldb/test/API/tools/lldb-server/TestGdbRemoteAuxvSupport.py
lldb/test/API/tools/lldb-server/TestGdbRemoteCompletion.py
lldb/test/API/tools/lldb-server/TestGdbRemoteExitCode.py
lldb/test/API/tools/lldb-server/TestGdbRemoteExpeditedRegisters.py
lldb/test/API/tools/lldb-server/TestGdbRemoteHostInfo.py
lldb/test/API/tools/lldb-server/TestGdbRemoteKill.py
lldb/test/API/tools/lldb-server/TestGdbRemoteProcessInfo.py
lldb/test/API/tools/lldb-server/TestGdbRemoteRegisterState.py
lldb/test/API/tools/lldb-server/TestGdbRemoteSingleStep.py
lldb/test/API/tools/lldb-server/TestGdbRemoteThreadsInStopReply.py
lldb/test/API/tools/lldb-server/TestGdbRemote_qThreadStopInfo.py
lldb/test/API/tools/lldb-server/TestLldbGdbServer.py
lldb/test/API/tools/lldb-server/commandline/TestGdbRemoteConnection.py
lldb/test/API/tools/lldb-server/inferior-crash/TestGdbRemoteAbort.py
lldb/test/API/tools/lldb-server/inferior-crash/TestGdbRemoteSegFault.py
lldb/test/API/tools/lldb-server/register-reading/TestGdbRemoteGPacket.py
Removed:
################################################################################
diff --git a/lldb/packages/Python/lldbsuite/test/dotest.py b/lldb/packages/Python/lldbsuite/test/dotest.py
index 86ea34ee2582..c728bf329202 100644
--- a/lldb/packages/Python/lldbsuite/test/dotest.py
+++ b/lldb/packages/Python/lldbsuite/test/dotest.py
@@ -852,11 +852,20 @@ def checkDebugInfoSupport():
def checkDebugServerSupport():
from lldbsuite.test import lldbplatformutil
+ import lldb
+ skip_msg = "Skipping %s tests, as they are not compatible with remote testing on this platform"
if lldbplatformutil.platformIsDarwin():
configuration.skip_categories.append("llgs")
+ if lldb.remote_platform:
+ # <rdar://problem/34539270>
+ configuration.skip_categories.append("debugserver")
+ print(skip_msg%"debugserver");
else:
configuration.skip_categories.append("debugserver")
+ if lldb.remote_platform and lldbplatformutil.getPlatform() == "windows":
+ configuration.skip_categories.append("llgs")
+ print(skip_msg%"lldb-server");
def run_suite():
# On MacOS X, check to make sure that domain for com.apple.DebugSymbols defaults
diff --git a/lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py b/lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py
index d9289251d89d..71e75adbecb7 100644
--- a/lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py
+++ b/lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py
@@ -199,9 +199,7 @@ def _init_llgs_test(self):
# Reverse connections may be tricky due to firewalls/NATs.
reverse_connect = False
- triple = self.dbg.GetSelectedPlatform().GetTriple()
- if re.match(".*-.*-windows", triple):
- self.skipTest("Remotely testing is not supported on Windows yet.")
+ # FIXME: This is extremely linux-oriented
# Grab the ppid from /proc/[shell pid]/stat
err, retcode, shell_stat = self.run_platform_command(
diff --git a/lldb/test/API/tools/lldb-server/TestGdbRemoteAttach.py b/lldb/test/API/tools/lldb-server/TestGdbRemoteAttach.py
index 84d44b5e0b84..9ffa7e26fab7 100644
--- a/lldb/test/API/tools/lldb-server/TestGdbRemoteAttach.py
+++ b/lldb/test/API/tools/lldb-server/TestGdbRemoteAttach.py
@@ -11,7 +11,6 @@ class TestGdbRemoteAttach(gdbremote_testcase.GdbRemoteTestCaseBase):
mydir = TestBase.compute_mydir(__file__)
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def attach_with_vAttach(self):
# Start the inferior, start the debug monitor, nothing is attached yet.
procs = self.prep_debug_monitor_and_inferior(
diff --git a/lldb/test/API/tools/lldb-server/TestGdbRemoteAuxvSupport.py b/lldb/test/API/tools/lldb-server/TestGdbRemoteAuxvSupport.py
index f9c8fadc15b9..9d9c4d89e0b5 100644
--- a/lldb/test/API/tools/lldb-server/TestGdbRemoteAuxvSupport.py
+++ b/lldb/test/API/tools/lldb-server/TestGdbRemoteAuxvSupport.py
@@ -10,7 +10,6 @@ class TestGdbRemoteAuxvSupport(gdbremote_testcase.GdbRemoteTestCaseBase):
AUXV_SUPPORT_FEATURE_NAME = "qXfer:auxv:read"
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def has_auxv_support(self):
inferior_args = ["message:main entered", "sleep:5"]
procs = self.prep_debug_monitor_and_inferior(
diff --git a/lldb/test/API/tools/lldb-server/TestGdbRemoteCompletion.py b/lldb/test/API/tools/lldb-server/TestGdbRemoteCompletion.py
index 5eec3c44f67a..e9eaab322821 100644
--- a/lldb/test/API/tools/lldb-server/TestGdbRemoteCompletion.py
+++ b/lldb/test/API/tools/lldb-server/TestGdbRemoteCompletion.py
@@ -34,7 +34,6 @@ def init_lldb_server(self):
def generate_hex_path(self, target):
return str(os.path.join(self.getBuildDir(), target)).encode().hex()
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
@llgs_test
def test_autocomplete_path(self):
self.build()
diff --git a/lldb/test/API/tools/lldb-server/TestGdbRemoteExitCode.py b/lldb/test/API/tools/lldb-server/TestGdbRemoteExitCode.py
index b42f8431c51e..961409d3fec2 100644
--- a/lldb/test/API/tools/lldb-server/TestGdbRemoteExitCode.py
+++ b/lldb/test/API/tools/lldb-server/TestGdbRemoteExitCode.py
@@ -25,10 +25,8 @@ def _test_inferior_exit(self, retval):
self.expect_gdbremote_sequence()
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_inferior_exit_0(self):
self._test_inferior_exit(0)
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_inferior_exit_42(self):
self._test_inferior_exit(42)
diff --git a/lldb/test/API/tools/lldb-server/TestGdbRemoteExpeditedRegisters.py b/lldb/test/API/tools/lldb-server/TestGdbRemoteExpeditedRegisters.py
index a07e227b1a44..103ecfd292cd 100644
--- a/lldb/test/API/tools/lldb-server/TestGdbRemoteExpeditedRegisters.py
+++ b/lldb/test/API/tools/lldb-server/TestGdbRemoteExpeditedRegisters.py
@@ -9,7 +9,6 @@ class TestGdbRemoteExpeditedRegisters(
mydir = TestBase.compute_mydir(__file__)
# <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
- @skipIfDarwinEmbedded
def gather_expedited_registers(self):
# Setup the stub and set the gdb remote command stream.
procs = self.prep_debug_monitor_and_inferior(inferior_args=["sleep:2"])
diff --git a/lldb/test/API/tools/lldb-server/TestGdbRemoteHostInfo.py b/lldb/test/API/tools/lldb-server/TestGdbRemoteHostInfo.py
index abb1a003d125..945f9d5ecf1f 100644
--- a/lldb/test/API/tools/lldb-server/TestGdbRemoteHostInfo.py
+++ b/lldb/test/API/tools/lldb-server/TestGdbRemoteHostInfo.py
@@ -99,20 +99,17 @@ def validate_darwin_minimum_host_info_keys(self, host_info_dict):
"qHostInfo is missing the following required "
"keys: " + str(missing_keys))
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
@debugserver_test
def test_qHostInfo_returns_at_least_one_key_val_pair_debugserver(self):
self.build()
self.get_qHostInfo_response()
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
@llgs_test
def test_qHostInfo_returns_at_least_one_key_val_pair_llgs(self):
self.build()
self.get_qHostInfo_response()
@skipUnlessDarwin
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
@debugserver_test
def test_qHostInfo_contains_darwin_required_keys_debugserver(self):
self.build()
@@ -120,7 +117,6 @@ def test_qHostInfo_contains_darwin_required_keys_debugserver(self):
self.validate_darwin_minimum_host_info_keys(host_info_dict)
@skipUnlessDarwin
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
@llgs_test
def test_qHostInfo_contains_darwin_required_keys_llgs(self):
self.build()
diff --git a/lldb/test/API/tools/lldb-server/TestGdbRemoteKill.py b/lldb/test/API/tools/lldb-server/TestGdbRemoteKill.py
index 94dcf7b6e171..98f07f3014e0 100644
--- a/lldb/test/API/tools/lldb-server/TestGdbRemoteKill.py
+++ b/lldb/test/API/tools/lldb-server/TestGdbRemoteKill.py
@@ -11,7 +11,6 @@ class TestGdbRemoteKill(gdbremote_testcase.GdbRemoteTestCaseBase):
mydir = TestBase.compute_mydir(__file__)
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_attach_commandline_kill_after_initial_stop(self):
self.build()
self.set_inferior_startup_attach()
diff --git a/lldb/test/API/tools/lldb-server/TestGdbRemoteProcessInfo.py b/lldb/test/API/tools/lldb-server/TestGdbRemoteProcessInfo.py
index 5d8c5e0840c5..d1b4e5e3a786 100644
--- a/lldb/test/API/tools/lldb-server/TestGdbRemoteProcessInfo.py
+++ b/lldb/test/API/tools/lldb-server/TestGdbRemoteProcessInfo.py
@@ -9,7 +9,6 @@ class TestGdbRemoteProcessInfo(gdbremote_testcase.GdbRemoteTestCaseBase):
mydir = TestBase.compute_mydir(__file__)
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_qProcessInfo_returns_running_process(self):
self.build()
procs = self.prep_debug_monitor_and_inferior()
@@ -32,7 +31,6 @@ def test_qProcessInfo_returns_running_process(self):
# If possible, verify that the process is running.
self.assertTrue(lldbgdbserverutils.process_is_running(pid, True))
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_attach_commandline_qProcessInfo_reports_correct_pid(self):
self.build()
self.set_inferior_startup_attach()
@@ -54,7 +52,6 @@ def test_attach_commandline_qProcessInfo_reports_correct_pid(self):
reported_pid = int(pid_text, base=16)
self.assertEqual(reported_pid, procs["inferior"].pid)
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_qProcessInfo_reports_valid_endian(self):
self.build()
procs = self.prep_debug_monitor_and_inferior()
@@ -121,7 +118,6 @@ def qProcessInfo_does_not_contain_keys(self, absent_key_set):
"the listed keys were present but unexpected in qProcessInfo result")
@add_test_categories(["debugserver"])
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_qProcessInfo_contains_cputype_cpusubtype(self):
self.build()
self.qProcessInfo_contains_keys(set(['cputype', 'cpusubtype']))
@@ -132,7 +128,6 @@ def test_qProcessInfo_contains_triple_ppid(self):
self.qProcessInfo_contains_keys(set(['triple', 'parent-pid']))
@add_test_categories(["debugserver"])
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_qProcessInfo_does_not_contain_triple(self):
self.build()
# We don't expect to see triple on darwin. If we do, we'll prefer triple
diff --git a/lldb/test/API/tools/lldb-server/TestGdbRemoteRegisterState.py b/lldb/test/API/tools/lldb-server/TestGdbRemoteRegisterState.py
index 849f5c96244d..e3784f46d78f 100644
--- a/lldb/test/API/tools/lldb-server/TestGdbRemoteRegisterState.py
+++ b/lldb/test/API/tools/lldb-server/TestGdbRemoteRegisterState.py
@@ -91,14 +91,12 @@ def grp_register_save_restore_works(self, with_suffix):
self.assertIsNotNone(final_reg_values)
self.assertEqual(final_reg_values, initial_reg_values)
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_grp_register_save_restore_works_with_suffix(self):
USE_THREAD_SUFFIX = True
self.build()
self.set_inferior_startup_launch()
self.grp_register_save_restore_works(USE_THREAD_SUFFIX)
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_grp_register_save_restore_works_no_suffix(self):
USE_THREAD_SUFFIX = False
self.build()
diff --git a/lldb/test/API/tools/lldb-server/TestGdbRemoteSingleStep.py b/lldb/test/API/tools/lldb-server/TestGdbRemoteSingleStep.py
index 09f729ca0dac..2716390da828 100644
--- a/lldb/test/API/tools/lldb-server/TestGdbRemoteSingleStep.py
+++ b/lldb/test/API/tools/lldb-server/TestGdbRemoteSingleStep.py
@@ -10,7 +10,6 @@ class TestGdbRemoteSingleStep(gdbremote_testcase.GdbRemoteTestCaseBase):
@skipIfWindows # No pty support to test any inferior std -i/e/o
@skipIf(triple='^mips')
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_single_step_only_steps_one_instruction_with_s(self):
self.build()
self.set_inferior_startup_launch()
diff --git a/lldb/test/API/tools/lldb-server/TestGdbRemoteThreadsInStopReply.py b/lldb/test/API/tools/lldb-server/TestGdbRemoteThreadsInStopReply.py
index 95e423678147..e66424f96295 100644
--- a/lldb/test/API/tools/lldb-server/TestGdbRemoteThreadsInStopReply.py
+++ b/lldb/test/API/tools/lldb-server/TestGdbRemoteThreadsInStopReply.py
@@ -166,7 +166,6 @@ def gather_threads_info_pcs(self, pc_register, little_endian):
return thread_pcs
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_QListThreadsInStopReply_supported(self):
self.build()
self.set_inferior_startup_launch()
@@ -183,7 +182,6 @@ def test_QListThreadsInStopReply_supported(self):
# delegate, e.g. llgs. So tests below to assert the stop threads number will all fail.
@expectedFailureAll(oslist=["windows"])
@skipIfNetBSD
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_stop_reply_reports_multiple_threads(self):
self.build()
self.set_inferior_startup_launch()
@@ -193,7 +191,6 @@ def test_stop_reply_reports_multiple_threads(self):
self.ENABLE_THREADS_IN_STOP_REPLY_ENTRIES, 5)
self.assertEqual(len(stop_reply_threads), 5)
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
@expectedFailureAll(oslist=["windows"])
@skipIfNetBSD
def test_no_QListThreadsInStopReply_supplies_no_threads(self):
@@ -206,7 +203,6 @@ def test_no_QListThreadsInStopReply_supplies_no_threads(self):
@expectedFailureAll(oslist=["windows"])
@skipIfNetBSD
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_stop_reply_reports_correct_threads(self):
self.build()
self.set_inferior_startup_launch()
@@ -234,7 +230,6 @@ def test_stop_reply_reports_correct_threads(self):
@expectedFailureAll(oslist=["windows"])
@skipIfNetBSD
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_stop_reply_contains_thread_pcs(self):
self.build()
self.set_inferior_startup_launch()
diff --git a/lldb/test/API/tools/lldb-server/TestGdbRemote_qThreadStopInfo.py b/lldb/test/API/tools/lldb-server/TestGdbRemote_qThreadStopInfo.py
index f8ecf5509b56..e76ccec067ab 100644
--- a/lldb/test/API/tools/lldb-server/TestGdbRemote_qThreadStopInfo.py
+++ b/lldb/test/API/tools/lldb-server/TestGdbRemote_qThreadStopInfo.py
@@ -13,8 +13,6 @@ class TestGdbRemote_qThreadStopInfo(gdbremote_testcase.GdbRemoteTestCaseBase):
mydir = TestBase.compute_mydir(__file__)
THREAD_COUNT = 5
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
- @skipIfDarwinEmbedded # <rdar://problem/27005337>
def gather_stop_replies_via_qThreadStopInfo(self, thread_count):
# Set up the inferior args.
inferior_args = []
diff --git a/lldb/test/API/tools/lldb-server/TestLldbGdbServer.py b/lldb/test/API/tools/lldb-server/TestLldbGdbServer.py
index d3bbfe03dbd8..0a93f2ceba08 100644
--- a/lldb/test/API/tools/lldb-server/TestLldbGdbServer.py
+++ b/lldb/test/API/tools/lldb-server/TestLldbGdbServer.py
@@ -25,7 +25,6 @@ class LldbGdbServerTestCase(gdbremote_testcase.GdbRemoteTestCaseBase, DwarfOpcod
mydir = TestBase.compute_mydir(__file__)
@debugserver_test
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_exe_starts_debugserver(self):
server = self.connect_to_debug_monitor()
@@ -46,7 +45,6 @@ def thread_suffix_supported(self):
self.expect_gdbremote_sequence()
@debugserver_test
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_thread_suffix_supported_debugserver(self):
self.thread_suffix_supported()
@@ -66,7 +64,6 @@ def list_threads_in_stop_reply_supported(self):
self.expect_gdbremote_sequence()
@debugserver_test
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_list_threads_in_stop_reply_supported_debugserver(self):
self.list_threads_in_stop_reply_supported()
@@ -84,7 +81,6 @@ def c_packet_works(self):
self.expect_gdbremote_sequence()
@debugserver_test
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_c_packet_works_debugserver(self):
self.build()
self.c_packet_works()
@@ -107,7 +103,6 @@ def inferior_print_exit(self):
self.assertIsNotNone(context)
@debugserver_test
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_inferior_print_exit_debugserver(self):
self.build()
self.inferior_print_exit()
@@ -133,7 +128,6 @@ def first_launch_stop_reply_thread_matches_first_qC(self):
self.expect_gdbremote_sequence()
@debugserver_test
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_first_launch_stop_reply_thread_matches_first_qC_debugserver(self):
self.build()
self.first_launch_stop_reply_thread_matches_first_qC()
@@ -167,7 +161,6 @@ def attach_commandline_continue_app_exits(self):
procs["inferior"].pid, False))
@debugserver_test
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_attach_commandline_continue_app_exits_debugserver(self):
self.build()
self.set_inferior_startup_attach()
@@ -196,7 +189,6 @@ def qRegisterInfo_returns_one_valid_result(self):
lldbgdbserverutils.parse_reg_info_response(reg_info_packet))
@debugserver_test
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_qRegisterInfo_returns_one_valid_result_debugserver(self):
self.build()
self.qRegisterInfo_returns_one_valid_result()
@@ -219,7 +211,6 @@ def qRegisterInfo_returns_all_valid_results(self):
self.assert_valid_reg_info(reg_info)
@debugserver_test
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_qRegisterInfo_returns_all_valid_results_debugserver(self):
self.build()
self.qRegisterInfo_returns_all_valid_results()
@@ -258,7 +249,6 @@ def qRegisterInfo_contains_required_generics(self):
self.assertTrue('flags' in generic_regs)
@debugserver_test
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_qRegisterInfo_contains_required_generics_debugserver(self):
self.build()
self.qRegisterInfo_contains_required_generics()
@@ -285,7 +275,6 @@ def qRegisterInfo_contains_at_least_one_register_set(self):
self.assertTrue(len(register_sets) >= 1)
@debugserver_test
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_qRegisterInfo_contains_at_least_one_register_set_debugserver(
self):
self.build()
@@ -357,7 +346,6 @@ def qThreadInfo_contains_thread(self):
self.assertEqual(len(threads), 1)
@debugserver_test
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_qThreadInfo_contains_thread_launch_debugserver(self):
self.build()
self.set_inferior_startup_launch()
@@ -370,7 +358,6 @@ def test_qThreadInfo_contains_thread_launch_llgs(self):
self.qThreadInfo_contains_thread()
@debugserver_test
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_qThreadInfo_contains_thread_attach_debugserver(self):
self.build()
self.set_inferior_startup_attach()
@@ -412,7 +399,6 @@ def qThreadInfo_matches_qC(self):
self.assertEqual(threads[0], QC_thread_id)
@debugserver_test
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_qThreadInfo_matches_qC_launch_debugserver(self):
self.build()
self.set_inferior_startup_launch()
@@ -425,7 +411,6 @@ def test_qThreadInfo_matches_qC_launch_llgs(self):
self.qThreadInfo_matches_qC()
@debugserver_test
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_qThreadInfo_matches_qC_attach_debugserver(self):
self.build()
self.set_inferior_startup_attach()
@@ -492,7 +477,6 @@ def p_returns_correct_data_size_for_each_qRegisterInfo(self):
reg_index += 1
@debugserver_test
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_p_returns_correct_data_size_for_each_qRegisterInfo_launch_debugserver(
self):
self.build()
@@ -508,7 +492,6 @@ def test_p_returns_correct_data_size_for_each_qRegisterInfo_launch_llgs(
self.p_returns_correct_data_size_for_each_qRegisterInfo()
@debugserver_test
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_p_returns_correct_data_size_for_each_qRegisterInfo_attach_debugserver(
self):
self.build()
@@ -556,7 +539,6 @@ def Hg_switches_to_3_threads(self):
self.assertEqual(int(context.get("thread_id"), 16), thread)
@debugserver_test
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_Hg_switches_to_3_threads_launch_debugserver(self):
self.build()
self.set_inferior_startup_launch()
@@ -570,7 +552,6 @@ def test_Hg_switches_to_3_threads_launch_llgs(self):
self.Hg_switches_to_3_threads()
@debugserver_test
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_Hg_switches_to_3_threads_attach_debugserver(self):
self.build()
self.set_inferior_startup_attach()
@@ -696,7 +677,6 @@ def Hc_then_Csignal_signals_correct_thread(self, segfault_signo):
@expectedFailure
@debugserver_test
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_Hc_then_Csignal_signals_correct_thread_launch_debugserver(self):
self.build()
self.set_inferior_startup_launch()
@@ -767,7 +747,6 @@ def m_packet_reads_memory(self):
self.assertEqual(read_contents, MEMORY_CONTENTS)
@debugserver_test
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_m_packet_reads_memory_debugserver(self):
self.build()
self.set_inferior_startup_launch()
@@ -792,7 +771,6 @@ def qMemoryRegionInfo_is_supported(self):
self.expect_gdbremote_sequence()
@debugserver_test
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_qMemoryRegionInfo_is_supported_debugserver(self):
self.build()
self.set_inferior_startup_launch()
@@ -853,7 +831,6 @@ def qMemoryRegionInfo_reports_code_address_as_executable(self):
self.assert_address_within_memory_region(code_address, mem_region_dict)
@debugserver_test
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_qMemoryRegionInfo_reports_code_address_as_executable_debugserver(
self):
self.build()
@@ -917,7 +894,6 @@ def qMemoryRegionInfo_reports_stack_address_as_readable_writeable(self):
stack_address, mem_region_dict)
@debugserver_test
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_qMemoryRegionInfo_reports_stack_address_as_readable_writeable_debugserver(
self):
self.build()
@@ -981,7 +957,6 @@ def qMemoryRegionInfo_reports_heap_address_as_readable_writeable(self):
self.assert_address_within_memory_region(heap_address, mem_region_dict)
@debugserver_test
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_qMemoryRegionInfo_reports_heap_address_as_readable_writeable_debugserver(
self):
self.build()
@@ -1129,7 +1104,6 @@ def breakpoint_set_and_remove_work(self, want_hardware=False):
self.assertIsNotNone(context)
@debugserver_test
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_software_breakpoint_set_and_remove_work_debugserver(self):
if self.getArchitecture() == "arm":
# TODO: Handle case when setting breakpoint in thumb code
@@ -1155,7 +1129,6 @@ def test_software_breakpoint_set_and_remove_work_llgs(self):
@skipUnlessPlatform(oslist=['linux'])
@expectedFailureAndroid
@skipIf(archs=no_match(['arm', 'aarch64']))
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_hardware_breakpoint_set_and_remove_work_debugserver(self):
if self.getArchitecture() == "arm":
# TODO: Handle case when setting breakpoint in thumb code
@@ -1192,7 +1165,6 @@ def qSupported_returns_known_stub_features(self):
self.assertTrue(len(supported_dict) > 0)
@debugserver_test
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_qSupported_returns_known_stub_features_debugserver(self):
self.build()
self.set_inferior_startup_launch()
@@ -1264,7 +1236,6 @@ def written_M_content_reads_back_correctly(self):
self.assertEqual(printed_message, TEST_MESSAGE + "X")
@debugserver_test
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_written_M_content_reads_back_correctly_debugserver(self):
self.build()
self.set_inferior_startup_launch()
@@ -1313,7 +1284,6 @@ def P_writes_all_gpr_registers(self):
# Come back to this. I have the test rigged to verify that at least some
# of the bit-flip writes work.
@debugserver_test
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_P_writes_all_gpr_registers_debugserver(self):
self.build()
self.set_inferior_startup_launch()
@@ -1436,7 +1406,6 @@ def P_and_p_thread_suffix_work(self):
# Note: as of this moment, a hefty number of the GPR writes are failing
# with E32 (everything except rax-rdx, rdi, rsi, rbp).
@debugserver_test
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def test_P_and_p_thread_suffix_work_debugserver(self):
self.build()
self.set_inferior_startup_launch()
diff --git a/lldb/test/API/tools/lldb-server/commandline/TestGdbRemoteConnection.py b/lldb/test/API/tools/lldb-server/commandline/TestGdbRemoteConnection.py
index dda7d707a56f..44815019d1ab 100644
--- a/lldb/test/API/tools/lldb-server/commandline/TestGdbRemoteConnection.py
+++ b/lldb/test/API/tools/lldb-server/commandline/TestGdbRemoteConnection.py
@@ -12,8 +12,6 @@ class TestGdbRemoteConnection(gdbremote_testcase.GdbRemoteTestCaseBase):
mydir = TestBase.compute_mydir(__file__)
@debugserver_test
- # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
- @skipIfDarwinEmbedded
def test_reverse_connect_debugserver(self):
self._reverse_connect()
diff --git a/lldb/test/API/tools/lldb-server/inferior-crash/TestGdbRemoteAbort.py b/lldb/test/API/tools/lldb-server/inferior-crash/TestGdbRemoteAbort.py
index 8bce3b9aa87b..7df73ce4cbce 100644
--- a/lldb/test/API/tools/lldb-server/inferior-crash/TestGdbRemoteAbort.py
+++ b/lldb/test/API/tools/lldb-server/inferior-crash/TestGdbRemoteAbort.py
@@ -9,7 +9,6 @@
class TestGdbRemoteAbort(gdbremote_testcase.GdbRemoteTestCaseBase):
mydir = TestBase.compute_mydir(__file__)
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def inferior_abort_received(self):
procs = self.prep_debug_monitor_and_inferior(inferior_args=["abort"])
self.assertIsNotNone(procs)
diff --git a/lldb/test/API/tools/lldb-server/inferior-crash/TestGdbRemoteSegFault.py b/lldb/test/API/tools/lldb-server/inferior-crash/TestGdbRemoteSegFault.py
index b9b4bef01177..7a018bfd7f86 100644
--- a/lldb/test/API/tools/lldb-server/inferior-crash/TestGdbRemoteSegFault.py
+++ b/lldb/test/API/tools/lldb-server/inferior-crash/TestGdbRemoteSegFault.py
@@ -11,7 +11,6 @@ class TestGdbRemoteSegFault(gdbremote_testcase.GdbRemoteTestCaseBase):
GDB_REMOTE_STOP_CODE_BAD_ACCESS = 0x91
- @skipIfDarwinEmbedded # <rdar://problem/34539270> lldb-server tests not updated to work on ios etc yet
def inferior_seg_fault_received(self, expected_signo):
procs = self.prep_debug_monitor_and_inferior(
inferior_args=["segfault"])
diff --git a/lldb/test/API/tools/lldb-server/register-reading/TestGdbRemoteGPacket.py b/lldb/test/API/tools/lldb-server/register-reading/TestGdbRemoteGPacket.py
index 1380b63955b7..fb4edc86f5b7 100644
--- a/lldb/test/API/tools/lldb-server/register-reading/TestGdbRemoteGPacket.py
+++ b/lldb/test/API/tools/lldb-server/register-reading/TestGdbRemoteGPacket.py
@@ -51,7 +51,6 @@ def run_test_g_packet(self):
@skipIfOutOfTreeDebugserver
@debugserver_test
- @skipIfDarwinEmbedded
def test_g_packet_debugserver(self):
self.run_test_g_packet()
More information about the llvm-branch-commits
mailing list