[llvm-branch-commits] [llvm] f019362 - [X86] EltsFromConsecutiveLoads - remove old FIXME comment. NFC.

Simon Pilgrim via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Wed Dec 2 09:26:33 PST 2020


Author: Simon Pilgrim
Date: 2020-12-02T17:21:41Z
New Revision: f019362329734ddc7d17fc76bcb7f2a4b3ea50a7

URL: https://github.com/llvm/llvm-project/commit/f019362329734ddc7d17fc76bcb7f2a4b3ea50a7
DIFF: https://github.com/llvm/llvm-project/commit/f019362329734ddc7d17fc76bcb7f2a4b3ea50a7.diff

LOG: [X86] EltsFromConsecutiveLoads - remove old FIXME comment. NFC.

Its unlikely an undef element in a zero vector will be any use.

Added: 
    

Modified: 
    llvm/lib/Target/X86/X86ISelLowering.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp
index 1a822c086b6a..56e098a48dd5 100644
--- a/llvm/lib/Target/X86/X86ISelLowering.cpp
+++ b/llvm/lib/Target/X86/X86ISelLowering.cpp
@@ -8398,8 +8398,6 @@ static SDValue EltsFromConsecutiveLoads(EVT VT, ArrayRef<SDValue> Elts,
   // Handle Special Cases - all undef or undef/zero.
   if (UndefMask.countPopulation() == NumElems)
     return DAG.getUNDEF(VT);
-
-  // FIXME: Should we return this as a BUILD_VECTOR instead?
   if ((ZeroMask.countPopulation() + UndefMask.countPopulation()) == NumElems)
     return VT.isInteger() ? DAG.getConstant(0, DL, VT)
                           : DAG.getConstantFP(0.0, DL, VT);


        


More information about the llvm-branch-commits mailing list