[llvm-branch-commits] [compiler-rt-branch] r369902 - Merging r366447:

Hans Wennborg via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Mon Aug 26 05:32:35 PDT 2019

Author: hans
Date: Mon Aug 26 05:32:35 2019
New Revision: 369902

URL: http://llvm.org/viewvc/llvm-project?rev=369902&view=rev
Merging r366447:
r366447 | jdevlieghere | 2019-07-18 17:17:42 +0200 (Thu, 18 Jul 2019) | 19 lines

[CMake] Don't set Python_ADDITIONAL_VERSIONS

Until recently, Python_ADDITIONAL_VERSIONS was used to limit LLVM's
Python support to 2.7. Now that both LLVM and LLDB both support Python
3, there's no longer a need to put an arbitrary limit on this.

However, instead of removing the variable, r365692 expanded the list,
which has the (presumably unintentional) side-effect of expression
preference for Python 3.

Instead, as Michal proposed in the original code review, we should just
not set the list at all, and let CMake pick whatever Python interpreter
you have in your path.

This patch removes the Python_ADDITIONAL_VERSIONS variable in llvm,
clang and lld. I've also updated the docs with the default behavior and
how to force a different Python version to be used.

Differential revision: https://reviews.llvm.org/D64894

    compiler-rt/branches/release_90/   (props changed)

Propchange: compiler-rt/branches/release_90/
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Aug 26 05:32:35 2019
@@ -1 +1 @@

Modified: compiler-rt/branches/release_90/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/branches/release_90/CMakeLists.txt?rev=369902&r1=369901&r2=369902&view=diff
--- compiler-rt/branches/release_90/CMakeLists.txt (original)
+++ compiler-rt/branches/release_90/CMakeLists.txt Mon Aug 26 05:32:35 2019
@@ -80,7 +80,6 @@ if (COMPILER_RT_STANDALONE_BUILD)
   # Find Python interpreter.
-  set(Python_ADDITIONAL_VERSIONS 2.7 2.6 2.5)
     message(FATAL_ERROR "

More information about the llvm-branch-commits mailing list