[Lldb-commits] [lldb] [lldb][test] Skip TestLldbGdbServer subtest on Darwin/NetBSD (PR #232249)
Raphael Isemann via lldb-commits
lldb-commits at lists.llvm.org
Thu Oct 15 03:03:04 PDT 2026
https://github.com/Teemperor created https://github.com/llvm/llvm-project/pull/232249
The test_Hc_then_Csignal_signals_correct_thread_launch is marked as XFAIL on Darwin/NetBSD. This test however 'fails' by waiting on a 60s timeout, which means the test spends most of its time just waiting for a timeout.
This patch skips the test instead. This reduces the runtime on Darwin from 77s to 15s.
Note that I don't know for sure why the test is failing, but the Darwin annotation has been around since the introduction of the test.
>From 849402266e14e2c16de1b29cb6d605729e9e9d63 Mon Sep 17 00:00:00 2001
From: Raphael Isemann <rise at apple.com>
Date: Thu, 15 Oct 2026 10:54:15 +0100
Subject: [PATCH] [lldb][test] Skip TestLldbGdbServer subtest on Darwin/NetBSD
The test_Hc_then_Csignal_signals_correct_thread_launch is marked as
XFAIL on Darwin/NetBSD. This test however 'fails' by waiting on a 60s
timeout, which means the test spends most of its time just waiting for
a timeout.
This patch skips the test instead. This reduces the runtime on Darwin
from 77s to 15s.
Note that I don't know for sure why the test is failing, but the Darwin
annotation has been around since the introduction of the test.
---
lldb/test/API/tools/lldb-server/TestLldbGdbServer.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lldb/test/API/tools/lldb-server/TestLldbGdbServer.py b/lldb/test/API/tools/lldb-server/TestLldbGdbServer.py
index d65febb01a13ab..99aa1b9b85e9b4 100644
--- a/lldb/test/API/tools/lldb-server/TestLldbGdbServer.py
+++ b/lldb/test/API/tools/lldb-server/TestLldbGdbServer.py
@@ -477,9 +477,9 @@ def Hc_then_Csignal_signals_correct_thread(self, segfault_signo):
post_handle_thread_id = int(post_handle_thread_id, 16)
self.assertEqual(post_handle_thread_id, print_thread_id)
- @expectedFailureDarwin
+ @skipIfDarwin
@requireSignals
- @expectedFailureNetBSD
+ @skipIfNetBSD
def test_Hc_then_Csignal_signals_correct_thread_launch(self):
self.build()
self.set_inferior_startup_launch()
More information about the lldb-commits
mailing list