[Lldb-commits] [lldb] [lldb][test] Skip TestLldbGdbServer subtest on Darwin/NetBSD (PR #232249)

[via lldb-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Raphael Isemann (Teemperor)

<details>
<summary>Changes</summary>

The test_Hc_then_Csignal_signals_correct_thread_launch is marked as XFAIL on Darwin/NetBSD. This test however 'fails' by waiting on a 60s timeout, which means the test spends most of its time just waiting for a timeout.

This patch skips the test instead. This reduces the runtime on Darwin from 77s to 15s.

Note that I don't know for sure why the test is failing, but the Darwin annotation has been around since the introduction of the test.

---
Full diff: https://github.com/llvm/llvm-project/pull/232249.diff


1 Files Affected:

- (modified) lldb/test/API/tools/lldb-server/TestLldbGdbServer.py (+2-2) 


``````````diff
diff --git a/lldb/test/API/tools/lldb-server/TestLldbGdbServer.py b/lldb/test/API/tools/lldb-server/TestLldbGdbServer.py
index d65febb01a13a..99aa1b9b85e9b 100644
--- a/lldb/test/API/tools/lldb-server/TestLldbGdbServer.py
+++ b/lldb/test/API/tools/lldb-server/TestLldbGdbServer.py
@@ -477,9 +477,9 @@ def Hc_then_Csignal_signals_correct_thread(self, segfault_signo):
             post_handle_thread_id = int(post_handle_thread_id, 16)
             self.assertEqual(post_handle_thread_id, print_thread_id)
 
-    @expectedFailureDarwin
+    @skipIfDarwin
     @requireSignals
-    @expectedFailureNetBSD
+    @skipIfNetBSD
     def test_Hc_then_Csignal_signals_correct_thread_launch(self):
         self.build()
         self.set_inferior_startup_launch()

``````````

</details>


https://github.com/llvm/llvm-project/pull/232249