[Lldb-commits] [lldb] [lldb] Speed up evaluating breakpoint conditions by using DIL (PR #224740)

[via lldb-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions h,cpp -- lldb/include/lldb/API/SBBreakpoint.h lldb/include/lldb/Breakpoint/Breakpoint.h lldb/include/lldb/Breakpoint/BreakpointLocation.h lldb/include/lldb/Breakpoint/StopCondition.h lldb/include/lldb/Interpreter/CommandOptionArgumentTable.h lldb/include/lldb/Target/Target.h lldb/include/lldb/lldb-enumerations.h lldb/source/API/SBBreakpoint.cpp lldb/source/Breakpoint/Breakpoint.cpp lldb/source/Breakpoint/BreakpointLocation.cpp lldb/source/Commands/CommandObjectBreakpoint.cpp lldb/source/Target/Target.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/lldb/source/Breakpoint/Breakpoint.cpp b/lldb/source/Breakpoint/Breakpoint.cpp
index ad2d7479b..3e24eb748 100644
--- a/lldb/source/Breakpoint/Breakpoint.cpp
+++ b/lldb/source/Breakpoint/Breakpoint.cpp
@@ -482,9 +482,7 @@ const StopCondition &Breakpoint::GetCondition() const {
   return m_options.GetCondition();
 }
 
-StopCondition &Breakpoint::GetCondition() {
-  return m_options.GetCondition();
-}
+StopCondition &Breakpoint::GetCondition() { return m_options.GetCondition(); }
 
 // This function is used when "baton" doesn't need to be freed
 void Breakpoint::SetCallback(BreakpointHitCallback callback, void *baton,

``````````

</details>


https://github.com/llvm/llvm-project/pull/224740