[Lldb-commits] [lldb] [lldb] Speed up evaluating breakpoint conditions by using DIL (PR #224740)

[Ilia Kuklin via lldb-commits]

kuilpd wrote:

> The one thing that's a little odd is that eBreakpointConditionModeDefault is part of the internal enum, but you can't set the target property to that. That's actually obvious if you think about it a bit, but it might be nice to state somewhere. For instance, Target::GetBreakpointsConditionMode will never return eBreakpointConditionModeDefault (you rely on that when it's used to evaluate the condition) even though supposedly it can return any member of the enum. Might be worth documenting that behavior.
> 
> Again, it really has to work that way, being told that the default is the default is silly. And you actually had to go to a little trouble to make that work correctly (by leaving it out of the property definition) which someone looking at all of lldb and not just this patch might not notice. So it would save a bit of thinking if you note that fact.

I added descriptions for all the modes in `lldb-enumerations.h`, so that people wouldn't have to dig through command option help if they see this enum in the code.

Should I also add some documentation somewhere, or a release note? Maybe the release note should be a separate PR with other DIL-related changes.

https://github.com/llvm/llvm-project/pull/224740