[Lldb-commits] [lldb] [lldb] Speed up evaluating breakpoint conditions by using DIL (PR #224740)

[Ilia Kuklin via lldb-commits]

kuilpd wrote:

> There should definitely be an `SBBreakpoint::{Set,Get}ConditionMode`. Since this doesn't affect the resolver, you don't need to have a way to set it on construction, so this should be a straightforward addition - just these two methods.

Done. I had to add a non-const `Breakpoint::GetCondition()` interface to be able to change the `StopCondition`, hopefully that's okay.

> It would be okay to also have a global setting, but not for the purposes of an IDE. IDE's should be managing breakpoints using the SB API's so they can use SetConditionMode directly. That's also a more robust way to do this, since then users can't change the behavior out from under the UI by changing the setting.

I ended up adding the global setting too. It sets the default mode, which can be overwritten per-breakpoint via command line setting or SB API.

https://github.com/llvm/llvm-project/pull/224740