[Lldb-commits] [lldb] 57011c9 - [NFC][lldb][windows] Default empty user-defined destructors (#199037)

[via lldb-commits]

Author: Charles Zablit
Date: 2026-05-21T16:24:59+01:00
New Revision: 57011c962565846b7343915ff3489b91cd036da1

URL: https://github.com/llvm/llvm-project/commit/57011c962565846b7343915ff3489b91cd036da1
DIFF: https://github.com/llvm/llvm-project/commit/57011c962565846b7343915ff3489b91cd036da1.diff

LOG: [NFC][lldb][windows] Default empty user-defined destructors (#199037)

Added: 
    

Modified: 
    lldb/include/lldb/Host/windows/MainLoopWindows.h
    lldb/source/Host/windows/ConnectionConPTYWindows.cpp
    lldb/source/Plugins/Process/Windows/Common/ExceptionRecord.h
    lldb/source/Plugins/Process/Windows/Common/IDebugDelegate.h
    lldb/source/Plugins/Process/Windows/Common/NativeThreadWindows.h
    lldb/source/Plugins/Process/Windows/Common/ProcessDebugger.cpp
    lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp
    lldb/source/Plugins/Process/Windows/Common/RegisterContextWindows.cpp
    lldb/source/Plugins/Process/Windows/Common/arm/RegisterContextWindows_arm.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/include/lldb/Host/windows/MainLoopWindows.h b/lldb/include/lldb/Host/windows/MainLoopWindows.h
index 65b44aa1582c3..d3fcda22299ef 100644
--- a/lldb/include/lldb/Host/windows/MainLoopWindows.h
+++ b/lldb/include/lldb/Host/windows/MainLoopWindows.h
@@ -36,7 +36,7 @@ class MainLoopWindows : public MainLoopBase {
   class IOEvent {
   public:
     IOEvent(handle_t event) : m_event(event) {}
-    virtual ~IOEvent() {}
+    virtual ~IOEvent() = default;
     virtual void WillPoll() {}
     virtual void DidPoll() {}
     virtual void Disarm() {}

diff  --git a/lldb/source/Host/windows/ConnectionConPTYWindows.cpp b/lldb/source/Host/windows/ConnectionConPTYWindows.cpp
index d370aa7a77e1b..e9d026fc7dc9f 100644
--- a/lldb/source/Host/windows/ConnectionConPTYWindows.cpp
+++ b/lldb/source/Host/windows/ConnectionConPTYWindows.cpp
@@ -18,7 +18,7 @@ using namespace lldb_private;
 ConnectionConPTY::ConnectionConPTY(std::shared_ptr<PseudoConsole> pty)
     : ConnectionGenericFile(pty->GetSTDOUTHandle(), false), m_pty(pty) {}
 
-ConnectionConPTY::~ConnectionConPTY() {}
+ConnectionConPTY::~ConnectionConPTY() = default;
 
 lldb::ConnectionStatus ConnectionConPTY::Connect(llvm::StringRef s,
                                                  Status *error_ptr) {

diff  --git a/lldb/source/Plugins/Process/Windows/Common/ExceptionRecord.h b/lldb/source/Plugins/Process/Windows/Common/ExceptionRecord.h
index 4499698369f59..6a55d0046796a 100644
--- a/lldb/source/Plugins/Process/Windows/Common/ExceptionRecord.h
+++ b/lldb/source/Plugins/Process/Windows/Common/ExceptionRecord.h
@@ -50,7 +50,7 @@ class ExceptionRecord {
         m_arguments(record.ExceptionInformation,
                     record.ExceptionInformation + record.NumberParameters) {}
 
-  virtual ~ExceptionRecord() {}
+  virtual ~ExceptionRecord() = default;
 
   DWORD
   GetExceptionCode() const { return m_code; }

diff  --git a/lldb/source/Plugins/Process/Windows/Common/IDebugDelegate.h b/lldb/source/Plugins/Process/Windows/Common/IDebugDelegate.h
index aff2dd610eea0..687ccab10bf0c 100644
--- a/lldb/source/Plugins/Process/Windows/Common/IDebugDelegate.h
+++ b/lldb/source/Plugins/Process/Windows/Common/IDebugDelegate.h
@@ -24,7 +24,7 @@ class HostThread;
 // notification of events that happen in a debugged process.
 class IDebugDelegate {
 public:
-  virtual ~IDebugDelegate() {}
+  virtual ~IDebugDelegate() = default;
 
   virtual void OnExitProcess(uint32_t exit_code) = 0;
   virtual void OnDebuggerConnected(lldb::addr_t image_base) = 0;

diff  --git a/lldb/source/Plugins/Process/Windows/Common/NativeThreadWindows.h b/lldb/source/Plugins/Process/Windows/Common/NativeThreadWindows.h
index 542bf769ba7b7..0c965665227db 100644
--- a/lldb/source/Plugins/Process/Windows/Common/NativeThreadWindows.h
+++ b/lldb/source/Plugins/Process/Windows/Common/NativeThreadWindows.h
@@ -23,7 +23,7 @@ class NativeThreadWindows : public NativeThreadProtocol {
 public:
   NativeThreadWindows(NativeProcessWindows &process, const HostThread &thread);
 
-  ~NativeThreadWindows() {}
+  ~NativeThreadWindows() override = default;
 
   Status DoStop();
   Status DoResume(lldb::StateType resume_state);

diff  --git a/lldb/source/Plugins/Process/Windows/Common/ProcessDebugger.cpp b/lldb/source/Plugins/Process/Windows/Common/ProcessDebugger.cpp
index 531b4e43b6e72..0748bde171832 100644
--- a/lldb/source/Plugins/Process/Windows/Common/ProcessDebugger.cpp
+++ b/lldb/source/Plugins/Process/Windows/Common/ProcessDebugger.cpp
@@ -63,7 +63,7 @@ static bool IsPageExecutable(uint32_t protect) {
 
 namespace lldb_private {
 
-ProcessDebugger::~ProcessDebugger() {}
+ProcessDebugger::~ProcessDebugger() = default;
 
 lldb::pid_t ProcessDebugger::GetDebuggedProcessId() const {
   if (m_session_data)

diff  --git a/lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp b/lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp
index eb1c4acc0f2bb..eb10701636d8d 100644
--- a/lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp
+++ b/lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp
@@ -126,7 +126,7 @@ ProcessWindows::ProcessWindows(lldb::TargetSP target_sp,
           RegisterContextWindows::GetNumHardwareBreakpointSlots(),
           LLDB_INVALID_BREAK_ID) {}
 
-ProcessWindows::~ProcessWindows() {}
+ProcessWindows::~ProcessWindows() = default;
 
 Status ProcessWindows::EnableBreakpointSite(BreakpointSite *bp_site) {
   if (bp_site->HardwareRequired())

diff  --git a/lldb/source/Plugins/Process/Windows/Common/RegisterContextWindows.cpp b/lldb/source/Plugins/Process/Windows/Common/RegisterContextWindows.cpp
index 25b67bec3e3cf..db1583168ae4f 100644
--- a/lldb/source/Plugins/Process/Windows/Common/RegisterContextWindows.cpp
+++ b/lldb/source/Plugins/Process/Windows/Common/RegisterContextWindows.cpp
@@ -30,7 +30,7 @@ RegisterContextWindows::RegisterContextWindows(Thread &thread,
     : RegisterContext(thread, concrete_frame_idx), m_context(),
       m_context_stale(true) {}
 
-RegisterContextWindows::~RegisterContextWindows() {}
+RegisterContextWindows::~RegisterContextWindows() = default;
 
 void RegisterContextWindows::InvalidateAllRegisters() {
   m_context_stale = true;

diff  --git a/lldb/source/Plugins/Process/Windows/Common/arm/RegisterContextWindows_arm.cpp b/lldb/source/Plugins/Process/Windows/Common/arm/RegisterContextWindows_arm.cpp
index 6f0efc257695d..064bee9ac73ef 100644
--- a/lldb/source/Plugins/Process/Windows/Common/arm/RegisterContextWindows_arm.cpp
+++ b/lldb/source/Plugins/Process/Windows/Common/arm/RegisterContextWindows_arm.cpp
@@ -80,7 +80,7 @@ RegisterContextWindows_arm::RegisterContextWindows_arm(
     Thread &thread, uint32_t concrete_frame_idx)
     : RegisterContextWindows(thread, concrete_frame_idx) {}
 
-RegisterContextWindows_arm::~RegisterContextWindows_arm() {}
+RegisterContextWindows_arm::~RegisterContextWindows_arm() = default;
 
 size_t RegisterContextWindows_arm::GetRegisterCount() {
   return std::size(g_register_infos_arm);