[Lldb-commits] [lldb] [lldb][Windows] Cache thread context in NativeRegisterContextWindows_arm64 (PR #197385)

[Ayush Sahay via lldb-commits]

================
@@ -101,35 +101,67 @@ CreateRegisterInfoInterface(const ArchSpec &target_arch) {
       target_arch, RegisterInfoPOSIX_arm64::eRegsetMaskDefault);
 }
 
-static Status GetThreadContextHelper(lldb::thread_t thread_handle,
-                                     PCONTEXT context_ptr,
-                                     const DWORD control_flag) {
+static Status
+GetThreadContextHelper(lldb::thread_t thread_handle, DWORD context_flags,
+                       PCONTEXT &context,
+                       std::shared_ptr<DataBufferHeap> &context_buffer) {
----------------
ayushsahay1837 wrote:

Agreed. After taking a closer look, I realized that _GetThreadContextHelper_ doesn’t actually need to own the context buffer; it just needs to resize and populate it. So, I've updated _GetThreadContextHelper_ to take a _DataBufferHeap *_ and left the management of the _DataBufferHeap_ object's lifetime to the callers. What do you think?

https://github.com/llvm/llvm-project/pull/197385