[Lldb-commits] [lldb] [lldb] Use os_unfair_lock for the string pool on Darwin (PR #197851)

[via lldb-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

The build failed before running any tests. Click on a failure below to see the details.

<details>
<summary>[code=1] tools/lldb/source/Utility/CMakeFiles/lldbUtility.dir/ConstString.cpp.obj</summary>

```
FAILED: [code=1] tools/lldb/source/Utility/CMakeFiles/lldbUtility.dir/ConstString.cpp.obj
sccache C:\clang\clang-msvc\bin\clang-cl.exe  /nologo -TP -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_ENABLE_EXTENDED_ALIGNED_STORAGE -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\_work\llvm-project\llvm-project\build\tools\lldb\source\Utility -IC:\_work\llvm-project\llvm-project\lldb\source\Utility -IC:\_work\llvm-project\llvm-project\lldb\include -IC:\_work\llvm-project\llvm-project\build\tools\lldb\include -IC:\_work\llvm-project\llvm-project\build\include -IC:\_work\llvm-project\llvm-project\llvm\include -IC:\_work\llvm-project\llvm-project\llvm\..\clang\include -IC:\_work\llvm-project\llvm-project\build\tools\lldb\..\clang\include -IC:\_work\llvm-project\llvm-project\lldb\source -IC:\_work\llvm-project\llvm-project\build\tools\lldb\source /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /Brepro /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported /Gw -Wno-vla-extension /O2 /Ob2  -std:c++17 -MD   -wd4018 -wd4068 -wd4150 -wd4201 -wd4251 -wd4521 -wd4530 -wd4589 -UNDEBUG /EHs-c- /GR- /showIncludes /Fotools\lldb\source\Utility\CMakeFiles\lldbUtility.dir\ConstString.cpp.obj /Fdtools\lldb\source\Utility\CMakeFiles\lldbUtility.dir\lldbUtility.pdb -c -- C:\_work\llvm-project\llvm-project\lldb\source\Utility\ConstString.cpp
C:\_work\llvm-project\llvm-project\lldb\source\Utility\ConstString.cpp(32,9): error: a type specifier is required for all declarations
32 | typedef PoolMutex = std::shared_mutex;
| ~~~~~~~ ^
C:\_work\llvm-project\llvm-project\lldb\source\Utility\ConstString.cpp(32,38): error: expected '(' for function-style cast or type construction
32 | typedef PoolMutex = std::shared_mutex;
|                     ~~~~~~~~~~~~~~~~~^
In file included from C:\_work\llvm-project\llvm-project\lldb\source\Utility\ConstString.cpp:22:
C:\BuildTools\VC\Tools\MSVC\14.44.35207\include\shared_mutex(217,13): error: member reference base type 'mutex_type' (aka 'int') is not a structure or union
217 |         _Mtx.lock_shared();
|         ~~~~^~~~~~~~~~~~
C:\_work\llvm-project\llvm-project\lldb\source\Utility\ConstString.cpp(109,35): note: in instantiation of member function 'std::shared_lock<int>::shared_lock' requested here
109 |       std::shared_lock<PoolMutex> lock(pool.m_mutex);
|                                   ^
In file included from C:\_work\llvm-project\llvm-project\lldb\source\Utility\ConstString.cpp:22:
C:\BuildTools\VC\Tools\MSVC\14.44.35207\include\shared_mutex(244,18): error: member reference base type 'int' is not a structure or union
244 |             _Pmtx->unlock_shared();
|             ~~~~~^ ~~~~~~~~~~~~~
C:\_work\llvm-project\llvm-project\lldb\source\Utility\ConstString.cpp(109,35): note: in instantiation of member function 'std::shared_lock<int>::~shared_lock' requested here
109 |       std::shared_lock<PoolMutex> lock(pool.m_mutex);
|                                   ^
In file included from C:\_work\llvm-project\llvm-project\lldb\source\Utility\ConstString.cpp:18:
In file included from C:\_work\llvm-project\llvm-project\llvm\include\llvm/Support/Threading.h:42:
C:\BuildTools\VC\Tools\MSVC\14.44.35207\include\mutex(445,17): error: member reference base type 'int' is not a structure or union
445 |         _MyMutex.lock();
|         ~~~~~~~~^~~~~
C:\_work\llvm-project\llvm-project\lldb\source\Utility\ConstString.cpp(139,34): note: in instantiation of member function 'std::lock_guard<int>::lock_guard' requested here
139 |       std::lock_guard<PoolMutex> lock(pool.m_mutex);
|                                  ^
In file included from C:\_work\llvm-project\llvm-project\lldb\source\Utility\ConstString.cpp:18:
In file included from C:\_work\llvm-project\llvm-project\llvm\include\llvm/Support/Threading.h:42:
C:\BuildTools\VC\Tools\MSVC\14.44.35207\include\mutex(452,17): error: member reference base type 'int' is not a structure or union
452 |         _MyMutex.unlock();
|         ~~~~~~~~^~~~~~~
C:\_work\llvm-project\llvm-project\lldb\source\Utility\ConstString.cpp(139,34): note: in instantiation of member function 'std::lock_guard<int>::~lock_guard' requested here
139 |       std::lock_guard<PoolMutex> lock(pool.m_mutex);
|                                  ^
6 errors generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/197851