[Lldb-commits] [lldb] [NFC][lldb][windows] refactor switch case braces (PR #197714)

[via lldb-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

The build failed before running any tests. Click on a failure below to see the details.

<details>
<summary>[code=1] tools/lldb/source/Plugins/Process/Windows/Common/CMakeFiles/lldbPluginProcessWindowsCommon.dir/NativeProcessWindows.cpp.obj</summary>

```
FAILED: [code=1] tools/lldb/source/Plugins/Process/Windows/Common/CMakeFiles/lldbPluginProcessWindowsCommon.dir/NativeProcessWindows.cpp.obj
sccache C:\clang\clang-msvc\bin\clang-cl.exe  /nologo -TP -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_ENABLE_EXTENDED_ALIGNED_STORAGE -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\_work\llvm-project\llvm-project\build\tools\lldb\source\Plugins\Process\Windows\Common -IC:\_work\llvm-project\llvm-project\lldb\source\Plugins\Process\Windows\Common -IC:\_work\llvm-project\llvm-project\lldb\include -IC:\_work\llvm-project\llvm-project\build\tools\lldb\include -IC:\_work\llvm-project\llvm-project\build\include -IC:\_work\llvm-project\llvm-project\llvm\include -IC:\_work\llvm-project\llvm-project\llvm\..\clang\include -IC:\_work\llvm-project\llvm-project\build\tools\lldb\..\clang\include -IC:\_work\llvm-project\llvm-project\lldb\source -IC:\_work\llvm-project\llvm-project\build\tools\lldb\source /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /Brepro /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported /Gw -Wno-vla-extension /O2 /Ob2  -std:c++17 -MD   -wd4018 -wd4068 -wd4150 -wd4201 -wd4251 -wd4521 -wd4530 -wd4589 -UNDEBUG /EHs-c- /GR- /showIncludes /Fotools\lldb\source\Plugins\Process\Windows\Common\CMakeFiles\lldbPluginProcessWindowsCommon.dir\NativeProcessWindows.cpp.obj /Fdtools\lldb\source\Plugins\Process\Windows\Common\CMakeFiles\lldbPluginProcessWindowsCommon.dir\lldbPluginProcessWindowsCommon.pdb -c -- C:\_work\llvm-project\llvm-project\lldb\source\Plugins\Process\Windows\Common\NativeProcessWindows.cpp
C:\_work\llvm-project\llvm-project\lldb\source\Plugins\Process\Windows\Common\NativeProcessWindows.cpp(608,73): error: function definition is not allowed here
608 | void NativeProcessWindows::OnCreateThread(const HostThread &new_thread) {
|                                                                         ^
C:\_work\llvm-project\llvm-project\lldb\source\Plugins\Process\Windows\Common\NativeProcessWindows.cpp(623,61): error: function definition is not allowed here
623 |                                         uint32_t exit_code) {
|                                                             ^
C:\_work\llvm-project\llvm-project\lldb\source\Plugins\Process\Windows\Common\NativeProcessWindows.cpp(639,64): error: function definition is not allowed here
639 |                                      lldb::addr_t module_addr) {
|                                                                ^
C:\_work\llvm-project\llvm-project\lldb\source\Plugins\Process\Windows\Common\NativeProcessWindows.cpp(645,66): error: function definition is not allowed here
645 | void NativeProcessWindows::OnUnloadDll(lldb::addr_t module_addr) {
|                                                                  ^
C:\_work\llvm-project\llvm-project\lldb\source\Plugins\Process\Windows\Common\NativeProcessWindows.cpp(653,61): error: function definition is not allowed here
653 |     NativeProcessProtocol::NativeDelegate &native_delegate) {
|                                                             ^
C:\_work\llvm-project\llvm-project\lldb\source\Plugins\Process\Windows\Common\NativeProcessWindows.cpp(664,78): error: function definition is not allowed here
664 |     lldb::pid_t pid, NativeProcessProtocol::NativeDelegate &native_delegate) {
|                                                                              ^
C:\_work\llvm-project\llvm-project\lldb\source\Plugins\Process\Windows\Common\NativeProcessWindows.cpp(673,28): error: expected '}'
673 | } // namespace lldb_private
|                            ^
C:\_work\llvm-project\llvm-project\lldb\source\Plugins\Process\Windows\Common\NativeProcessWindows.cpp(46,24): note: to match this '{'
46 | namespace lldb_private {
|                        ^
7 errors generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/197714