[Lldb-commits] [lldb] [lldb][NFCI] Delegate impl of ObjCLanguageRuntime::AddClass (PR #197410)

[via lldb-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Felipe de Azevedo Piovezan (felipepiovezan)

<details>
<summary>Changes</summary>

This is duplicated code.

---
Full diff: https://github.com/llvm/llvm-project/pull/197410.diff


1 Files Affected:

- (modified) lldb/source/Plugins/LanguageRuntime/ObjC/ObjCLanguageRuntime.cpp (+1-7) 


``````````diff
diff --git a/lldb/source/Plugins/LanguageRuntime/ObjC/ObjCLanguageRuntime.cpp b/lldb/source/Plugins/LanguageRuntime/ObjC/ObjCLanguageRuntime.cpp
index ad163347b14ca..29e29f59996bf 100644
--- a/lldb/source/Plugins/LanguageRuntime/ObjC/ObjCLanguageRuntime.cpp
+++ b/lldb/source/Plugins/LanguageRuntime/ObjC/ObjCLanguageRuntime.cpp
@@ -52,13 +52,7 @@ bool ObjCLanguageRuntime::IsAllowedRuntimeValue(ConstString name) {
 bool ObjCLanguageRuntime::AddClass(ObjCISA isa,
                                    const ClassDescriptorSP &descriptor_sp,
                                    const char *class_name) {
-  if (isa != 0) {
-    m_isa_to_descriptor[isa] = descriptor_sp;
-    // class_name is assumed to be valid
-    m_hash_to_isa_map.insert(std::make_pair(llvm::djbHash(class_name), isa));
-    return true;
-  }
-  return false;
+  return AddClass(isa, descriptor_sp, llvm::djbHash(class_name));
 }
 
 void ObjCLanguageRuntime::AddToMethodCache(lldb::addr_t class_addr,

``````````

</details>


https://github.com/llvm/llvm-project/pull/197410