[Lldb-commits] [lldb] [lldb] Add specific error message for "process plugin" with no plugin loaded (PR #196933)

[via lldb-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: David Spickett (DavidSpickett)

<details>
<summary>Changes</summary>

Fixes #<!-- -->196535.

The error was:
> command is not implemented

Which is incorrect. It is now:
> no process plugin commands are currently registered

Which is not very helpful either but it's not wrong at least. We could expand it but I'm not sure what would help anyone here, given how rare it is that anyone encounters this anyway.

---
Full diff: https://github.com/llvm/llvm-project/pull/196933.diff


2 Files Affected:

- (modified) lldb/source/Commands/CommandObjectProcess.cpp (+4) 
- (added) lldb/test/Shell/Commands/command-process-plugin-no-plugin.test (+3) 


``````````diff
diff --git a/lldb/source/Commands/CommandObjectProcess.cpp b/lldb/source/Commands/CommandObjectProcess.cpp
index 551f98566a9a5..390a3340d4990 100644
--- a/lldb/source/Commands/CommandObjectProcess.cpp
+++ b/lldb/source/Commands/CommandObjectProcess.cpp
@@ -952,6 +952,10 @@ class CommandObjectProcessPlugin : public CommandObjectProxy {
       return process->GetPluginCommandObject();
     return nullptr;
   }
+
+  llvm::StringRef GetUnsupportedError() override {
+    return "no process plugin commands are currently registered";
+  }
 };
 
 // CommandObjectProcessLoad
diff --git a/lldb/test/Shell/Commands/command-process-plugin-no-plugin.test b/lldb/test/Shell/Commands/command-process-plugin-no-plugin.test
new file mode 100644
index 0000000000000..b582bda04954a
--- /dev/null
+++ b/lldb/test/Shell/Commands/command-process-plugin-no-plugin.test
@@ -0,0 +1,3 @@
+# RUN: not %lldb -b -o "process plugin" 2>&1 | FileCheck %s
+
+# CHECK: error: no process plugin commands are currently registered

``````````

</details>


https://github.com/llvm/llvm-project/pull/196933