[Lldb-commits] [lldb] Fix the modal private state thread we use for running expressions on the private state thread (PR #179799)

[via lldb-commits]

================
@@ -2878,10 +2892,18 @@ Status Process::LoadCore() {
         Listener::MakeListener("lldb.process.load_core_listener"));
     HijackProcessEvents(listener_sp);
 
-    if (PrivateStateThreadIsValid())
+    if (PrivateStateThreadIsRunning())
       ResumePrivateStateThread();
-    else
-      StartPrivateStateThread();
+    else {
+      StartPrivateStateThread(lldb::eStateStopped,
+                              /*RunLock Is stopped*/ false);
+      if (!m_current_private_state_thread) {
+        // FIXME: We are not going to get any further here. The only way this
----------------
jimingham wrote:

It was a reminder to me to do an experiment of artificially forcing this test to fail and seeing that we handled it as gracefully as we could, but no longer relevant.  I took it out of most of them, but missed these.  I'll take out the rest.

https://github.com/llvm/llvm-project/pull/179799