[Lldb-commits] [lldb] Fix the modal private state thread we use for running expressions on the private state thread (PR #179799)

[via lldb-commits]

================
@@ -3064,10 +3062,14 @@ void PruneThreadPlans();
     std::string m_exit_string;
   };
 
-  bool PrivateStateThreadIsValid() const {
-    lldb::StateType state = m_private_state.GetValue();
+  bool PrivateStateThreadIsRunning() const {
+    if (!m_current_private_state_thread ||
+        !m_current_private_state_thread->IsRunning())
+      return false;
+
+    lldb::StateType state = m_current_private_state_thread->GetPrivateState();
     return state != lldb::eStateInvalid && state != lldb::eStateDetached &&
-           state != lldb::eStateExited && m_private_state_thread.IsJoinable();
+           state != lldb::eStateExited;
----------------
jimingham wrote:

That isn't equivalent.  We are asking here "is the private state thread doing work".  The private state thread is still doing work when the process is stopped, it's just waiting for someone to start it up again.  It's not going to do any more work if the process is exited, however, for instance.

https://github.com/llvm/llvm-project/pull/179799