[Lldb-commits] [lldb] Fix the modal private state thread we use for running expressions on the private state thread (PR #179799)

[via lldb-commits]

================
@@ -3071,10 +3093,7 @@ Status Process::Attach(ProcessAttachInfo &attach_info) {
       if (wait_for_launch) {
         error = WillAttachToProcessWithName(process_name, wait_for_launch);
         if (error.Success()) {
-          m_public_run_lock.SetRunning();
           m_should_detach = true;
-          const bool restarted = false;
-          SetPublicState(eStateAttaching, restarted);
----------------
jimingham wrote:

That work gets done by the call to:

StartPrivateStateThread(lldb::eStateAttaching, true);

on line 3111 below.  The "Do..." calls into the process plugin don't spin the private state thread, so you don't need to set the state before you start up the private state thread, and so moving it to the StartPrivateStateThread is correct. 

https://github.com/llvm/llvm-project/pull/179799