[Lldb-commits] [lldb] [lldb][lldb-dap][NFC] Fix swapped logging directions for DAP messages. (PR #131544)

Ebuka Ezike via lldb-commits lldb-commits at lists.llvm.org
Sun Mar 16 16:27:55 PDT 2025


https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/131544

The logging markers for incoming ("<--") and outgoing ("-->") messages were incorrectly reversed. from #7790d69

>From bdfcf3a3d15c2c8f72d6a553027287eb0f43a3d4 Mon Sep 17 00:00:00 2001
From: Ebuka Ezike <yerimyah1 at gmail.com>
Date: Sun, 16 Mar 2025 23:25:58 +0000
Subject: [PATCH] [lldb][lldb-dap][NFC] Fix swapped logging directions for DAP
 messages.

The logging markers for incoming ("<--") and outgoing ("-->")
messages were incorrectly reversed. from #7790d69
---
 lldb/tools/lldb-dap/Transport.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lldb/tools/lldb-dap/Transport.cpp b/lldb/tools/lldb-dap/Transport.cpp
index db2d7228d3fb7..a721662a345eb 100644
--- a/lldb/tools/lldb-dap/Transport.cpp
+++ b/lldb/tools/lldb-dap/Transport.cpp
@@ -103,7 +103,7 @@ Expected<std::optional<Message>> Transport::Read() {
   if (raw_json->length() != length)
     return createStringError("unexpected EOF parse DAP message body");
 
-  DAP_LOG(m_log, "<-- ({0}) {1}", m_client_name, *raw_json);
+  DAP_LOG(m_log, "--> ({0}) {1}", m_client_name, *raw_json);
 
   return json::parse<Message>(*raw_json);
 }
@@ -114,7 +114,7 @@ Error Transport::Write(const Message &message) {
 
   std::string json = formatv("{0}", toJSON(message)).str();
 
-  DAP_LOG(m_log, "--> ({0}) {1}", m_client_name, json);
+  DAP_LOG(m_log, "<-- ({0}) {1}", m_client_name, json);
 
   std::string Output;
   raw_string_ostream OS(Output);



More information about the lldb-commits mailing list