[Lldb-commits] [lldb] 8705e48 - [lldb] Remove use of comma operator (NFC) (#131233)

[via lldb-commits]

Author: Dave Lee
Date: 2025-03-16T08:41:55-07:00
New Revision: 8705e489dc17eb7124aca5070201d2dd234f97c1

URL: https://github.com/llvm/llvm-project/commit/8705e489dc17eb7124aca5070201d2dd234f97c1
DIFF: https://github.com/llvm/llvm-project/commit/8705e489dc17eb7124aca5070201d2dd234f97c1.diff

LOG: [lldb] Remove use of comma operator (NFC) (#131233)

No reason for the comma operator, make this more conventional with two statements.

Added: 
    

Modified: 
    lldb/source/ValueObject/ValueObjectSyntheticFilter.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/ValueObject/ValueObjectSyntheticFilter.cpp b/lldb/source/ValueObject/ValueObjectSyntheticFilter.cpp
index d49c27f0006bc..ae2b9bebbb12d 100644
--- a/lldb/source/ValueObject/ValueObjectSyntheticFilter.cpp
+++ b/lldb/source/ValueObject/ValueObjectSyntheticFilter.cpp
@@ -362,7 +362,9 @@ lldb::ValueObjectSP ValueObjectSynthetic::GetNonSyntheticValue() {
 }
 
 void ValueObjectSynthetic::CopyValueData(ValueObject *source) {
-  m_value = (source->UpdateValueIfNeeded(), source->GetValue());
+  if (!source->UpdateValueIfNeeded())
+    return;
+  m_value = source->GetValue();
   ExecutionContext exe_ctx(GetExecutionContextRef());
   m_error = m_value.GetValueAsData(&exe_ctx, m_data, GetModule().get());
 }