[Lldb-commits] [lldb] [lldb][lldb-dap][NFC] Fix swapped logging directions for DAP messages. (PR #131544)
via lldb-commits
lldb-commits at lists.llvm.org
Sun Mar 16 16:28:33 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-lldb
Author: Ebuka Ezike (da-viper)
<details>
<summary>Changes</summary>
The logging markers for incoming ("<--") and outgoing ("-->") messages were incorrectly reversed. from #<!-- -->7790d69
---
Full diff: https://github.com/llvm/llvm-project/pull/131544.diff
1 Files Affected:
- (modified) lldb/tools/lldb-dap/Transport.cpp (+2-2)
``````````diff
diff --git a/lldb/tools/lldb-dap/Transport.cpp b/lldb/tools/lldb-dap/Transport.cpp
index db2d7228d3fb7..a721662a345eb 100644
--- a/lldb/tools/lldb-dap/Transport.cpp
+++ b/lldb/tools/lldb-dap/Transport.cpp
@@ -103,7 +103,7 @@ Expected<std::optional<Message>> Transport::Read() {
if (raw_json->length() != length)
return createStringError("unexpected EOF parse DAP message body");
- DAP_LOG(m_log, "<-- ({0}) {1}", m_client_name, *raw_json);
+ DAP_LOG(m_log, "--> ({0}) {1}", m_client_name, *raw_json);
return json::parse<Message>(*raw_json);
}
@@ -114,7 +114,7 @@ Error Transport::Write(const Message &message) {
std::string json = formatv("{0}", toJSON(message)).str();
- DAP_LOG(m_log, "--> ({0}) {1}", m_client_name, json);
+ DAP_LOG(m_log, "<-- ({0}) {1}", m_client_name, json);
std::string Output;
raw_string_ostream OS(Output);
``````````
</details>
https://github.com/llvm/llvm-project/pull/131544
More information about the lldb-commits
mailing list