[Lldb-commits] [lldb] [lldb-dap] Restore the override FD used by the output redirect on stop. (PR #129964)

Thu Mar 6 13:59:53 PST 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `cross-project-tests-sie-ubuntu` running on `doug-worker-1a` while building `lldb` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/181/builds/14956

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
1.017 [157/8/8] Building CXX object tools/clang/lib/Basic/CMakeFiles/obj.clangBasic.dir/Version.cpp.o
2.364 [156/8/9] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/FunctionBreakpoint.cpp.o
3.163 [155/8/10] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/EventHelper.cpp.o
3.369 [154/8/11] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/ExceptionBreakpoint.cpp.o
4.180 [153/8/12] Building CXX object lib/Object/CMakeFiles/LLVMObject.dir/IRSymtab.cpp.o
4.287 [152/8/13] Linking CXX static library lib/libLLVMObject.a
4.677 [151/8/14] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/InstructionBreakpoint.cpp.o
5.787 [150/8/15] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/DAP.cpp.o
5.939 [149/8/16] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/LLDBUtils.cpp.o
6.581 [148/8/17] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/OutputRedirector.cpp.o
FAILED: tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/OutputRedirector.cpp.o 
/opt/ccache/bin/g++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -DLLVM_BUILD_STATIC -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/build/tools/lldb/tools/lldb-dap -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/tools/lldb-dap -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/include -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/build/tools/lldb/include -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/build/include -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/llvm/include -I/usr/include/python3.8 -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/llvm/../clang/include -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/build/tools/lldb/../clang/include -isystem /usr/include/libxml2 -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -Wno-unknown-pragmas -Wno-strict-aliasing -Wno-stringop-truncation -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/OutputRedirector.cpp.o -MF tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/OutputRedirector.cpp.o.d -o tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/OutputRedirector.cpp.o -c /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/tools/lldb-dap/OutputRedirector.cpp
/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/tools/lldb-dap/OutputRedirector.cpp: In member function ‘llvm::Error lldb_dap::OutputRedirector::RedirectTo(FILE*, std::function<void(llvm::StringRef)>)’:
/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/tools/lldb-dap/OutputRedirector.cpp:59:7: error: ‘override’ was not declared in this scope
   59 |   if (override) {
      |       ^~~~~~~~
/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/tools/lldb-dap/OutputRedirector.cpp: In member function ‘void lldb_dap::OutputRedirector::Stop()’:
/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/tools/lldb-dap/OutputRedirector.cpp:108:18: warning: ignoring return value of ‘ssize_t write(int, const void*, size_t)’, declared with attribute warn_unused_result [-Wunused-result]
  108 |     (void)::write(fd, kCloseSentinel.data(), kCloseSentinel.size());
      |           ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
7.321 [148/7/18] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/lldb-dap.cpp.o
7.533 [148/6/19] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/SourceBreakpoint.cpp.o
8.283 [148/5/20] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/JSONUtils.cpp.o
8.395 [148/4/21] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Watchpoint.cpp.o
8.708 [148/3/22] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/AttachRequestHandler.cpp.o
15.729 [148/2/23] Building CXX object lib/CodeGen/AsmPrinter/CMakeFiles/LLVMAsmPrinter.dir/AsmPrinter.cpp.o
16.444 [148/1/24] Building CXX object lib/LTO/CMakeFiles/LLVMLTO.dir/LTO.cpp.o
ninja: build stopped: subcommand failed.

```

</details>

https://github.com/llvm/llvm-project/pull/129964