[Lldb-commits] [lldb] [lldb-dap] Restore the override FD used by the output redirect on stop. (PR #129964)

Thu Mar 6 14:11:48 PST 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running on `linaro-lldb-arm-ubuntu` while building `lldb` at step 4 "build".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/12507

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 4 (build) failure: build (failure)
...
61.872 [1/24/6511] Linking CXX executable bin/lldb
62.225 [1/23/6512] Linking CXX executable bin/c-index-test
62.465 [1/22/6513] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/DataBreakpointInfoRequestHandler.cpp.o
62.529 [1/21/6514] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/JSONUtils.cpp.o
62.853 [1/20/6515] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/NextRequestHandler.cpp.o
63.134 [1/19/6516] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/DAP.cpp.o
63.533 [1/18/6517] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/DisconnectRequestHandler.cpp.o
63.648 [1/17/6518] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/ExceptionBreakpoint.cpp.o
63.821 [1/16/6519] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/lldb-dap.cpp.o
63.848 [1/15/6520] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/OutputRedirector.cpp.o
FAILED: tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/OutputRedirector.cpp.o 
/usr/local/bin/c++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -DLLVM_BUILD_STATIC -D_DEBUG -D_FILE_OFFSET_BITS=64 -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D_LARGEFILE_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/tools/lldb/tools/lldb-dap -I/home/tcwg-buildbot/worker/lldb-arm-ubuntu/llvm-project/lldb/tools/lldb-dap -I/home/tcwg-buildbot/worker/lldb-arm-ubuntu/llvm-project/lldb/include -I/home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/tools/lldb/include -I/home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/include -I/home/tcwg-buildbot/worker/lldb-arm-ubuntu/llvm-project/llvm/include -I/usr/include/python3.10 -I/home/tcwg-buildbot/worker/lldb-arm-ubuntu/llvm-project/llvm/../clang/include -I/home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/tools/lldb/../clang/include -isystem /usr/include/libxml2 -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wno-unknown-pragmas -Wno-strict-aliasing -Wno-vla-extension -O3 -DNDEBUG -std=c++17  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/OutputRedirector.cpp.o -MF tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/OutputRedirector.cpp.o.d -o tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/OutputRedirector.cpp.o -c /home/tcwg-buildbot/worker/lldb-arm-ubuntu/llvm-project/lldb/tools/lldb-dap/OutputRedirector.cpp
../llvm-project/lldb/tools/lldb-dap/OutputRedirector.cpp:59:7: error: use of undeclared identifier 'override'
   59 |   if (override) {
      |       ^
../llvm-project/lldb/tools/lldb-dap/OutputRedirector.cpp:60:30: error: use of undeclared identifier 'override'
   60 |     int override_fd = fileno(override);
      |                              ^
2 errors generated.
63.883 [1/14/6521] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/PauseRequestHandler.cpp.o
63.902 [1/13/6522] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/ConfigurationDoneRequestHandler.cpp.o
64.262 [1/12/6523] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/CompileUnitsRequestHandler.cpp.o
64.278 [1/11/6524] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/ModulesRequestHandler.cpp.o
64.285 [1/10/6525] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/StackTraceRequestHandler.cpp.o
64.436 [1/9/6526] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/CompletionsHandler.cpp.o
64.635 [1/8/6527] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/SetBreakpointsRequestHandler.cpp.o
64.754 [1/7/6528] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/ExceptionInfoRequestHandler.cpp.o
64.821 [1/6/6529] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/ReadMemoryRequestHandler.cpp.o
64.930 [1/5/6530] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/SetDataBreakpointsRequestHandler.cpp.o
64.958 [1/4/6531] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/RestartRequestHandler.cpp.o
65.012 [1/3/6532] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/VariablesRequestHandler.cpp.o
65.235 [1/2/6533] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/SetFunctionBreakpointsRequestHandler.cpp.o
65.328 [1/1/6534] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/DisassembleRequestHandler.cpp.o
ninja: build stopped: subcommand failed.

```

</details>

https://github.com/llvm/llvm-project/pull/129964