[Lldb-commits] [lldb] [lldb-dap] Restore the override FD used by the output redirect on stop. (PR #129964)

Thu Mar 6 13:59:50 PST 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `lldb-x86_64-debian` running on `lldb-x86_64-debian` while building `lldb` at step 4 "build".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/162/builds/17524

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 4 (build) failure: build (failure)
...
2.780 [123/39/18] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/DataBreakpointInfoRequestHandler.cpp.o
2.809 [123/38/19] Building CXX object tools/llvm-config/CMakeFiles/llvm-config.dir/llvm-config.cpp.o
2.840 [122/38/20] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/DisassembleRequestHandler.cpp.o
2.878 [122/37/21] Linking CXX executable bin/llvm-config
2.885 [122/36/22] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/InitializeRequestHandler.cpp.o
2.911 [122/35/23] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/BreakpointLocationsHandler.cpp.o
2.965 [122/34/24] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/SetBreakpointsRequestHandler.cpp.o
3.044 [122/33/25] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/FunctionBreakpoint.cpp.o
3.066 [122/32/26] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/StepOutRequestHandler.cpp.o
3.076 [122/31/27] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/OutputRedirector.cpp.o
FAILED: tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/OutputRedirector.cpp.o 
/usr/bin/clang++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -DLLVM_BUILD_STATIC -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/worker/2.0.1/lldb-x86_64-debian/build/tools/lldb/tools/lldb-dap -I/home/worker/2.0.1/lldb-x86_64-debian/llvm-project/lldb/tools/lldb-dap -I/home/worker/2.0.1/lldb-x86_64-debian/llvm-project/lldb/include -I/home/worker/2.0.1/lldb-x86_64-debian/build/tools/lldb/include -I/home/worker/2.0.1/lldb-x86_64-debian/build/include -I/home/worker/2.0.1/lldb-x86_64-debian/llvm-project/llvm/include -I/usr/include/python3.11 -I/home/worker/2.0.1/lldb-x86_64-debian/llvm-project/llvm/../clang/include -I/home/worker/2.0.1/lldb-x86_64-debian/build/tools/lldb/../clang/include -isystem /usr/include/libxml2 -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wno-unknown-pragmas -Wno-strict-aliasing -Wno-vla-extension -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/OutputRedirector.cpp.o -MF tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/OutputRedirector.cpp.o.d -o tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/OutputRedirector.cpp.o -c /home/worker/2.0.1/lldb-x86_64-debian/llvm-project/lldb/tools/lldb-dap/OutputRedirector.cpp
/home/worker/2.0.1/lldb-x86_64-debian/llvm-project/lldb/tools/lldb-dap/OutputRedirector.cpp:59:7: error: use of undeclared identifier 'override'
  if (override) {
      ^
/home/worker/2.0.1/lldb-x86_64-debian/llvm-project/lldb/tools/lldb-dap/OutputRedirector.cpp:60:30: error: use of undeclared identifier 'override'
    int override_fd = fileno(override);
                             ^
2 errors generated.
3.097 [122/30/28] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/EvaluateRequestHandler.cpp.o
3.099 [122/29/29] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/StepInRequestHandler.cpp.o
3.142 [122/28/30] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/ThreadsRequestHandler.cpp.o
3.159 [122/27/31] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/SetExceptionBreakpointsRequestHandler.cpp.o
3.160 [122/26/32] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Watchpoint.cpp.o
3.168 [122/25/33] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/TestGetTargetBreakpointsRequestHandler.cpp.o
3.177 [122/24/34] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/LLDBUtils.cpp.o
3.199 [122/23/35] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/SetVariableRequestHandler.cpp.o
3.201 [122/22/36] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/ContinueRequestHandler.cpp.o
3.238 [122/21/37] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/CompileUnitsRequestHandler.cpp.o
3.245 [122/20/38] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/RequestHandler.cpp.o
3.263 [122/19/39] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/SourceRequestHandler.cpp.o
3.264 [122/18/40] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/ScopesRequestHandler.cpp.o
3.269 [122/17/41] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/LaunchRequestHandler.cpp.o
3.282 [122/16/42] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/SetDataBreakpointsRequestHandler.cpp.o
3.308 [122/15/43] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/EventHelper.cpp.o
3.325 [122/14/44] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/SetFunctionBreakpointsRequestHandler.cpp.o
3.328 [122/13/45] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/SourceBreakpoint.cpp.o
3.341 [122/12/46] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/VariablesRequestHandler.cpp.o
3.367 [122/11/47] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/StepInTargetsRequestHandler.cpp.o
3.380 [122/10/48] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/SetInstructionBreakpointsRequestHandler.cpp.o
3.417 [122/9/49] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/CompletionsHandler.cpp.o
3.464 [122/8/50] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/StackTraceRequestHandler.cpp.o
3.515 [122/7/51] Building CXX object lib/Object/CMakeFiles/LLVMObject.dir/IRSymtab.cpp.o
3.655 [122/6/52] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/Handler/ReadMemoryRequestHandler.cpp.o
4.207 [122/5/53] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/DAP.cpp.o
4.717 [122/4/54] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/JSONUtils.cpp.o
5.302 [122/3/55] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/lldb-dap.cpp.o
10.948 [122/2/56] Building CXX object lib/CodeGen/AsmPrinter/CMakeFiles/LLVMAsmPrinter.dir/AsmPrinter.cpp.o
12.164 [122/1/57] Building CXX object lib/LTO/CMakeFiles/LLVMLTO.dir/LTO.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/129964