[Lldb-commits] [lldb] [lldb-dap] show dialog when executable is not found (PR #104711)

Adrian Vogelsgesang via lldb-commits lldb-commits at lists.llvm.org
Mon Aug 19 13:28:54 PDT 2024


================
@@ -17,14 +17,46 @@ function createDefaultLLDBDapOptions(): LLDBDapOptions {
       const path = vscode.workspace
         .getConfiguration("lldb-dap", session.workspaceFolder)
         .get<string>("executable-path");
-      if (path) {
-        return new vscode.DebugAdapterExecutable(path, []);
+
+      if (!path) {
+        return packageJSONExecutable;
       }
-      return packageJSONExecutable;
+
+      vscode.workspace.fs.stat(vscode.Uri.file(path)).then(
+        (fileStats) => {
----------------
vogelsgesang wrote:

in addition to checking the presence of the file on launch, we could also check for it in the `onDidChangeConfiguration` event if the `executable-path` gets changed.

(100% optional; feel free to just ignore this comment 🙂)

https://github.com/llvm/llvm-project/pull/104711


More information about the lldb-commits mailing list