[Lldb-commits] [lldb] [lldb-dap] show dialog when executable is not found (PR #104711)

[Adrian Vogelsgesang via lldb-commits]

================
@@ -17,14 +17,46 @@ function createDefaultLLDBDapOptions(): LLDBDapOptions {
       const path = vscode.workspace
         .getConfiguration("lldb-dap", session.workspaceFolder)
         .get<string>("executable-path");
-      if (path) {
-        return new vscode.DebugAdapterExecutable(path, []);
+
+      if (!path) {
----------------
vogelsgesang wrote:

even if the path is not set, we should check if the `packageJSONExecutable` actually exists
By default, the `path` is not set. As such, new users would not get this error message, although those are the ones which are most likely to run into issues

https://github.com/llvm/llvm-project/pull/104711