[Lldb-commits] [PATCH] D158041: [lldb] [gdb-remote] Also handle high/low memory addressable bits setting in the stop info packet

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lldb/source/Utility/AddressableBits.cpp:62-64
+void AddressableBits::Clear() {
+  m_low_memory_addr_bits = m_high_memory_addr_bits = 0;
+}
----------------
jasonmolenda wrote:
> jasonmolenda wrote:
> > JDevlieghere wrote:
> > > Where is this called?
> > Hm.  When I thought of this patch last night, I was sure I needed a Clear method for some reason, but you're right I never ended up using it.
> AHA I did use it, but it's in the previous patch.  It's in the base class method of ObjectFile.
> 
> ```
>   virtual bool GetAddressableBits(lldb_private::AddressableBits &address_bits) {
>     address_bits.Clear();
>     return false;
>   } 
> ```
> 
Why is this returning a bool and not `AddressableBits`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158041/new/

https://reviews.llvm.org/D158041