[Lldb-commits] [PATCH] D158041: [lldb] [gdb-remote] Also handle high/low memory addressable bits setting in the stop info packet

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda added inline comments.


================
Comment at: lldb/source/Utility/AddressableBits.cpp:62-64
+void AddressableBits::Clear() {
+  m_low_memory_addr_bits = m_high_memory_addr_bits = 0;
+}
----------------
JDevlieghere wrote:
> jasonmolenda wrote:
> > jasonmolenda wrote:
> > > JDevlieghere wrote:
> > > > Where is this called?
> > > Hm.  When I thought of this patch last night, I was sure I needed a Clear method for some reason, but you're right I never ended up using it.
> > AHA I did use it, but it's in the previous patch.  It's in the base class method of ObjectFile.
> > 
> > ```
> >   virtual bool GetAddressableBits(lldb_private::AddressableBits &address_bits) {
> >     address_bits.Clear();
> >     return false;
> >   } 
> > ```
> > 
> Why is this returning a bool and not `AddressableBits`?
The `addressable_bits` argument is a `[out]` variable to indicate if it has a value.  You're right, now that there's a `HasValue` method, `ObjectFile::GetAddressableBits` can return an `AddressableBits` and the caller can call `HasValue`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158041/new/

https://reviews.llvm.org/D158041