[Lldb-commits] [PATCH] D158041: [lldb] [gdb-remote] Also handle high/low memory addressable bits setting in the stop info packet

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda updated this revision to Diff 550868.
jasonmolenda added a comment.

Update patch to change the `AddressableBits::IsValid` to `AddressableBits::HasValue` which is a clearer description.  The `IsValid` methods are used across the lldb_private classes everywhere.  I tried changing this to `operator bool` but I thought that was less clear in use.  I compromised by changing it to `HasValue` - this is a POD class so "IsValid" seemed a little questionable, but I didn't like operator bool.  Let's try this out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158041/new/

https://reviews.llvm.org/D158041

Files:
  lldb/docs/lldb-gdb-remote.txt
  lldb/include/lldb/Utility/AddressableBits.h
  lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  lldb/source/Utility/AddressableBits.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D158041.550868.patch
Type: text/x-patch
Size: 5072 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230816/59a9b308/attachment-0001.bin>