[Lldb-commits] [PATCH] D151366: [lldb] Disable variable watchpoints when going out of scope

[Med Ismail Bennani via Phabricator via lldb-commits]

mib added a comment.

In D151366#4372731 <https://reviews.llvm.org/D151366#4372731>, @aprantl wrote:

>> @aprantl Do you know if we can detect the end of the scope ? I'm not sure it's possible currently ... But even if we could do it, that wouldn't cover the following case:
>
> When setting a variable watchpoint, you would have to store the scope the variable is in, and then ignore all hits that are (1) on the same thread but (2) where the scope is not any of the lexical scopes in any of the stack frames. Because you still want to find modifications in child frames or on other threads.

As discussed offline, watchpoints still have many shortcomings that can't be addressed all at once, so I'll land this patch and document the various issues discussed here so hopefully we can find a solution for those.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151366/new/

https://reviews.llvm.org/D151366