[Lldb-commits] [PATCH] D151268: [lldb][DataFormatter] Add dereference support to libstdcpp std::shared_ptr formatter

Thu May 25 00:38:38 PDT 2023

Michael137 added a subscriber: compnerd.
Michael137 added a comment.

Any chance someone with a working aarch64 windows 10 setup could take a look? (@compnerd ?) Or let me know how I might be able to set this up.

The place where we seem to crash in `TestVarPath.py` is:

  # Make sure we don't crash when looking for non existant child     
  # in type with synthetic children. This used to cause a crash.     
  v = frame.GetValueForVariablePath('pt_sp->not_valid_child')        
  self.assertTrue(v.GetError().Fail(),                               
                  "Make sure we don't find 'pt_sp->not_valid_child'")

A crash that was previously addressed in `0d6f681292d5a`. Interestingly, the code path that was added in that patch is the one that we used to take before adding support for `$$dereference$$` in this patch.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151268/new/

https://reviews.llvm.org/D151268