[Lldb-commits] [PATCH] D149472: [lldb] Refactor host::OpenFileInExternalEditor

[Alex Langford via Phabricator via lldb-commits]

bulbazord accepted this revision.
bulbazord added a comment.

LGTM! Thanks for cleaning this up.



================
Comment at: lldb/source/Target/Thread.cpp:1762-1763
+                  frame_sc.line_entry.file, frame_sc.line_entry.line)) {
+            LLDB_LOG_ERROR(GetLog(LLDBLog::Host), std::move(e),
+                           "OpenFileInExternalEditor failed: {0}");
+          }
----------------
Not related to this change but I don't think I like `LLDB_LOG_ERROR`... I read this and I think "Oh, if logging is disabled, will this actually consume the error?". After all, the other logging macros do not have a side effect. It'd be nice if we could create a function and name it "ConsumeErrorAndLog" or something to be clearer that it actually consumes it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149472/new/

https://reviews.llvm.org/D149472