[Lldb-commits] [PATCH] D149472: [lldb] Refactor host::OpenFileInExternalEditor

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere updated this revision to Diff 518007.
JDevlieghere marked 10 inline comments as done.
JDevlieghere added a comment.

- Return an `llvm::Erorr` and percolate errors up
- Don't fall back to the default editor if the one specified can't be found
- Limit roles to editors only


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149472/new/

https://reviews.llvm.org/D149472

Files:
  lldb/include/lldb/Host/Host.h
  lldb/source/Host/common/Host.cpp
  lldb/source/Host/macosx/objcxx/Host.mm
  lldb/source/Interpreter/CommandInterpreter.cpp
  lldb/source/Target/Thread.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D149472.518007.patch
Type: text/x-patch
Size: 10287 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230428/19e62257/attachment.bin>