[Lldb-commits] [PATCH] D148380: [lldb] Lock accesses to PathMappingLists's internals

Alex Langford via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Apr 14 14:24:55 PDT 2023


bulbazord created this revision.
bulbazord added reviewers: JDevlieghere, mib, jingham, jasonmolenda.
Herald added a project: All.
bulbazord requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

This class is not safe in multithreaded code. It's possible for one
thread to modify a PathMappingList's `m_pair` vector while another
thread is iterating over it, effectively invalidating the iterator and
potentially leading to crashes or other difficult-to-diagnose bugs.

rdar://107695786


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D148380

Files:
  lldb/include/lldb/Target/PathMappingList.h
  lldb/source/Target/PathMappingList.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D148380.513748.patch
Type: text/x-patch
Size: 6854 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230414/373e2f0a/attachment.bin>


More information about the lldb-commits mailing list