[Lldb-commits] [PATCH] D147820: debugserver: move AArch64 watchpoint traps within a watchpointed region, parse ESR flags and send them to lldb

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda updated this revision to Diff 512577.
jasonmolenda added a comment.

Update patch to incorporate Jonas' & David's feedback.  I'm holding this patch until I can get the lldb changes to fix the reason:watchpoint `description` handling corrected, or the test case in this patch will fail.  This patch changes debugserver's watchpoint notification to be the same as AArch64 lldb-server, but that currently skips over watchpoint traps that originate outside the watched region and the test case will fail with that behavior.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147820/new/

https://reviews.llvm.org/D147820

Files:
  lldb/test/API/commands/watchpoints/unaligned-watchpoint/Makefile
  lldb/test/API/commands/watchpoints/unaligned-watchpoint/TestUnalignedWatchpoint.py
  lldb/test/API/commands/watchpoints/unaligned-watchpoint/main.c
  lldb/tools/debugserver/source/DNBBreakpoint.cpp
  lldb/tools/debugserver/source/DNBBreakpoint.h
  lldb/tools/debugserver/source/DNBDefs.h
  lldb/tools/debugserver/source/MacOSX/MachException.cpp
  lldb/tools/debugserver/source/MacOSX/MachProcess.h
  lldb/tools/debugserver/source/MacOSX/MachProcess.mm
  lldb/tools/debugserver/source/RNBRemote.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D147820.512577.patch
Type: text/x-patch
Size: 19779 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230411/7d73b980/attachment-0001.bin>