[Lldb-commits] [PATCH] D147748: [lldb] Implement SymbolFile::GetCompileOptions

[Augusto Noronha via Phabricator via lldb-commits]

augusto2112 added inline comments.


================
Comment at: lldb/include/lldb/Symbol/SymbolFile.h:441
+  /// associated with that compilation unit.
+  std::unordered_map<lldb::CompUnitSP, Args> GetCompileOptions() {
+    std::unordered_map<lldb::CompUnitSP, Args> args;
----------------
JDevlieghere wrote:
> Any reason you picked `unordered_map`? Not that I expected this code to be particularly hot, but I would've gone for an `llvm::DenseMap` which should offer much better performance characteristics. 
Mainly because there's no implementation of shared pointer as keys for dense maps (`DenseMapInfo<T>` where the `T` is a `shared_ptr`) at the moment, and I don't expect this to be super hot.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147748/new/

https://reviews.llvm.org/D147748