[Lldb-commits] [PATCH] D147748: [lldb] Implement SymbolFile::GetCompileOptions

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

LGTM with or without the DenseMap, whichever makes the most sense.



================
Comment at: lldb/include/lldb/Symbol/SymbolFile.h:441
+  /// associated with that compilation unit.
+  std::unordered_map<lldb::CompUnitSP, Args> GetCompileOptions() {
+    std::unordered_map<lldb::CompUnitSP, Args> args;
----------------
Any reason you picked `unordered_map`? Not that I expected this code to be particularly hot, but I would've gone for an `llvm::DenseMap` which should offer much better performance characteristics. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147748/new/

https://reviews.llvm.org/D147748