[Lldb-commits] [PATCH] D143690: [lldb] Add the ability to provide a message to a progress event update

[Dave Lee via Phabricator via lldb-commits]

kastiglione accepted this revision.
kastiglione added a comment.

nice



================
Comment at: lldb/include/lldb/Core/DebuggerEvents.h:48-49
+  }
+  const std::string &GetTitle() const { return m_title; }
+  const std::string &GetUpdate() const { return m_update; }
   bool IsDebuggerSpecific() const { return m_debugger_specific; }
----------------
Are these going to be needed in a follow up?


================
Comment at: lldb/include/lldb/Core/DebuggerEvents.h:54
+  std::string m_title;
+  std::string m_update;
   const uint64_t m_id;
----------------
minor quibble, but maybe `m_current_subtitle` (or some other `m_current_<noun>`) – I know that's wordy but "update" is a bit vague. Do as you please tho.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143690/new/

https://reviews.llvm.org/D143690